Change the "Edit My Reform" button in the Household Impact screen to say "View Economic Impact"

[Rohithvema79]

Description

Fixed #1894 issue

Changes

Changed the "edit my reform" button to "view economic impact", location->src/pages/household/HouseholdRightSidebar.jsx

Screenshots

Tests

Used make debug to test the file.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
policyengine-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 15, 2025 6:23am

[MaxGhenis]

could you drop a screenshot of the app after locally building?

[Rohithvema79]

could you drop a screenshot of the app after locally building?

Attached

[MaxGhenis]

Does that show up if the user hasn't defined a reform? In that case, we want that button to prompt them to design a reform, and only to view economic analysis if they've already done a reform.

[Rohithvema79]

Does that show up if the user hasn't defined a reform? In that case, we want that button to prompt them to design a reform, and only to view economic analysis if they've already done a reform.

I mean according to the issue given i solved it and that view economic impact is showing before creating a reform

[MaxGhenis]

If I'm understanding right, we want to change the EDIT MY REFORM button to say VIEW ECONOMIC IMPACTS when in the household view and a reform is present.

#1894 (comment)

[Rohithvema79]

If I'm understanding right, we want to change the EDIT MY REFORM button to say VIEW ECONOMIC IMPACTS when in the household view and a reform is present.

#1894 (comment)

could you please be more precise,
what have i done is not correct?

[Rohithvema79]

Or can you please post the screen shot where you need the text to be change

[anth-volk]

You're editing the right button, but applying the changes too broadly. What we're looking for is this:

1. If a user has input a household and a society-wide reform policy (as in the example link in Change the "Edit My Reform" button in the Household Impact screen to say "View Economic Impact"  #1894) and everything has finished calculating, we want the "Edit My Reform" button to say "View Economic Impact"
2. Otherwise, we want no change to what currently happens

[Rohithvema79]

Ok you're basically saying after user entered the values and after calculation then it must be changed to view economic impact till then it should be as edit my reform button right.Got it