Apply Nikhil's comments

PolicyEngine · Feb 13, 2025 · b307f43 · b307f43
1 parent 0245691
commit b307f43
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/policyengine_uk/parameters/gov/dwp/universal_childcare_entitlement/funding_rate.yaml b/policyengine_uk/parameters/gov/dwp/universal_childcare_entitlement/funding_rate.yaml
@@ -1,9 +1,9 @@
-description: The Department for Education converts childcare hours into expenses for extended childcare entitlement at these rates.
+description: The Department for Education converts childcare hours into expenses for universal childcare entitlement at this rate.
 metadata:
   type: single_amount
   threshold_unit: year
   amount_unit: currency-GBP
-  label: Extended childcare entitlement hourly rates
+  label: universal childcare entitlement hourly rates
   reference:
     - title: House of Commons Library
       href: https://commonslibrary.parliament.uk/research-briefings/cbp-8052/

diff --git a/policyengine_uk/parameters/gov/dwp/universal_childcare_entitlement/hours.yaml b/policyengine_uk/parameters/gov/dwp/universal_childcare_entitlement/hours.yaml
@@ -3,10 +3,13 @@ metadata:
   type: single_amount
   threshold_unit: year
   amount_unit: hour
-  label: Universal childcare entitlement hours
+  label: universal childcare entitlement hours
   reference:
     - title: Childcare (Early Years Provision Free of Charge) (Extended Entitlement) Regulations 2016 - Regulation 35(3)
       href: https://www.legislation.gov.uk/uksi/2016/1257/part/4/made
+    - title: Education Act 1996 - Section 8 (Compulsory School Age)
+      href: https://www.legislation.gov.uk/ukpga/1996/56/section/8
+      # In England, children are eligible for universal childcare entitlement from age 3 until they reach compulsory school age, which is defined as the start of the term after their fifth birthday.
 brackets:
   - threshold:
       2015-01-01: 0
@@ -19,4 +22,4 @@ brackets:
   - threshold:
       2015-01-01: 5
     amount:
-      2015-01-01: 0
+      2015-01-01: 0
diff --git a/...sts/policy/baseline/gov/dwp/universal_childcare_entitlement/universal_free_childcare.yaml b/...sts/policy/baseline/gov/dwp/universal_childcare_entitlement/universal_free_childcare.yaml
@@ -36,7 +36,7 @@
   output:
     universal_childcare_entitlement: [3351.60]
 
-- name: Multiple children different ages
+- name: Multiple children different ages, some eligible
   period: 2024
   input:
     people:

diff --git a/...e_uk/variables/gov/dwp/universal_childcare_entitlement/universal_childcare_entitlement.py b/...e_uk/variables/gov/dwp/universal_childcare_entitlement/universal_childcare_entitlement.py
@@ -15,7 +15,4 @@ def formula(person, period, parameters):
         # Get the funding rate from parameters
         p = parameters(period).gov.dwp.universal_childcare_entitlement
         rate = p.funding_rate
-
-        # Calculate total funding amount
-        total_entitlement = hours * rate
-        return total_entitlement
+        return hours * rate