Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax free childcare #1004

Merged
merged 65 commits into from
Feb 4, 2025
Merged

Tax free childcare #1004

merged 65 commits into from
Feb 4, 2025

Conversation

vahid-ahmadi
Copy link
Collaborator

@vahid-ahmadi vahid-ahmadi commented Jan 10, 2025

Overview

This PR implements the Tax-Free Childcare (TFC) scheme calculation in PolicyEngine UK. The scheme provides government contributions towards childcare costs for eligible families. (Documentation link)

Key Features

Fixes #1002

@MaxGhenis
Copy link
Collaborator

@PavelMakarchuk could you please meet with @vahid-ahmadi on this? Probably easier than text review for getting the parameters and vectorization in for the first time.

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come initial comments but will meet to discuss in detail

Copy link
Collaborator

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also still not clear on how this works wrt spouse income eligibility, can you check against another source like entitled to?

Also run make format

Copy link
Collaborator

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the benefit to the list of benefits so it flows to net income

@vahid-ahmadi
Copy link
Collaborator Author

I'm also still not clear on how this works wrt spouse income eligibility, can you check against another source like entitled to?

Also run make format

Program rules:

  • "You must include your partner in your application if you are married/civil partnership and live together, or living together as though you are"
  • Both partners must independently meet income requirements when in a couple

The code addresses this through:

  • benunit.all(benunit.members("tax_free_childcare_meets_income_requirements", period)) in tax_free_childcare_eligible - ensures both partners must independently satisfy income conditions
  • tax_free_childcare_work_condition handles couple-specific work requirements with couple_both_working | couple_one_working_one_disabled

The code correctly implements the partner eligibility rules from the program description. I will explain the code in the documentation in detail.

Copy link
Collaborator

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also run make format for the linecheck

Makes sense on the spousal earnings, it was ambiguous when we had earnings rather than hours (the guide said "you must earn at least x [based on age] and so must your spouse" which could have meant your spouse's earnings requirement also depended on your age) but is now more clear given the minimum wage standard

@nikhilwoodruff nikhilwoodruff merged commit 16cc0f0 into master Feb 4, 2025
2 checks passed
@nikhilwoodruff nikhilwoodruff deleted the tax-free-childcare-new branch February 4, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tax free childcare
4 participants