-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tax free childcare #1004
Tax free childcare #1004
Conversation
@PavelMakarchuk could you please meet with @vahid-ahmadi on this? Probably easier than text review for getting the parameters and vectorization in for the first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come initial comments but will meet to discuss in detail
...yengine_uk/variables/gov/hmrc/tax_free_childcare/conditions/childcare_age_child_condition.py
Outdated
Show resolved
Hide resolved
...yengine_uk/variables/gov/hmrc/tax_free_childcare/conditions/childcare_age_child_condition.py
Outdated
Show resolved
Hide resolved
policyengine_uk/variables/gov/hmrc/tax_free_childcare/tax-free-childcare-benefits.py
Outdated
Show resolved
Hide resolved
policyengine_uk/variables/gov/hmrc/tax_free_childcare/conditions/childcare_work_condition.py
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/childcare_subsidies/tax_free_childcare/age_limits.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/childcare_subsidies/tax_free_childcare/age_limits.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/childcare_subsidies/tax_free_childcare/age_limits.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/childcare_subsidies/tax_free_childcare/age_limits.yaml
Outdated
Show resolved
Hide resolved
...e_uk/parameters/gov/hmrc/childcare_subsidies/tax_free_childcare/contribution_parameters.yaml
Outdated
Show resolved
Hide resolved
...yengine_uk/variables/gov/hmrc/tax_free_childcare/conditions/childcare_age_child_condition.py
Outdated
Show resolved
Hide resolved
...yengine_uk/variables/gov/hmrc/tax_free_childcare/conditions/childcare_age_child_condition.py
Outdated
Show resolved
Hide resolved
policyengine_uk/variables/gov/hmrc/tax_free_childcare/conditions/childcare_income_condition.py
Outdated
Show resolved
Hide resolved
...e_uk/parameters/gov/hmrc/childcare_subsidies/tax_free_childcare/income_thresholds/adult.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/variables/gov/hmrc/tax_free_childcare/tax_free_childcare_benefits.py
Outdated
Show resolved
Hide resolved
...uk/variables/gov/hmrc/tax_free_childcare/conditions/childcare_incompatibilities_condition.py
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/incompatible_benefits.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/incompatible_benefits.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/incompatible_benefits.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/incompatible_benefits.yaml
Outdated
Show resolved
Hide resolved
...ables/gov/hmrc/tax_free_childcare/conditions/tax_free_childcare_meets_income_requirements.py
Outdated
Show resolved
Hide resolved
...ables/gov/hmrc/tax_free_childcare/conditions/tax_free_childcare_meets_income_requirements.py
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/income_thresholds.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/minimum_weekly_hours.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/max_income_thresholds.yaml
Outdated
Show resolved
Hide resolved
...e_uk/variables/gov/hmrc/tax_free_childcare/conditions/tax_free_childcare_program_eligible.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also still not clear on how this works wrt spouse income eligibility, can you check against another source like entitled to?
Also run make format
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/incompatible_benefits.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/investment_income_types.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the benefit to the list of benefits so it flows to net income
Program rules:
The code addresses this through:
The code correctly implements the partner eligibility rules from the program description. I will explain the code in the documentation in detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also run make format
for the linecheck
Makes sense on the spousal earnings, it was ambiguous when we had earnings rather than hours (the guide said "you must earn at least x [based on age] and so must your spouse" which could have meant your spouse's earnings requirement also depended on your age) but is now more clear given the minimum wage standard
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/investment_income_types.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/investment_income_types.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/investment_income_types.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/investment_income_types.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/age/disability.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/minimum_weekly_hours.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/minimum_weekly_hours.yaml
Outdated
Show resolved
Hide resolved
...k/tests/policy/baseline/gov/hmrc/tax_free_childcare/tax_free_childcare_income_condition.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/investment_income_types.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/investment_income_types.yaml
Outdated
Show resolved
Hide resolved
policyengine_uk/parameters/gov/hmrc/tax_free_childcare/income/countable_sources.yaml
Outdated
Show resolved
Hide resolved
…countable_sources.yaml Co-authored-by: Max Ghenis <[email protected]>
…ine/policyengine-uk into tax-free-childcare-new
Overview
This PR implements the Tax-Free Childcare (TFC) scheme calculation in PolicyEngine UK. The scheme provides government contributions towards childcare costs for eligible families. (Documentation link)
Key Features
Fixes #1002