Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate LWJGL3 and redo renderer #362

Merged
merged 15 commits into from
Oct 20, 2024
Merged

Isolate LWJGL3 and redo renderer #362

merged 15 commits into from
Oct 20, 2024

Conversation

Deftu
Copy link
Member

@Deftu Deftu commented Oct 10, 2024

Description

Isolated all usages of LWJGL 3 into their own isolated environment, not allowing them to pollute Minecraft's base usage of LWJGL.

This gives OneConfig maximal compatibility with mods which may mess around with LWJGL internals and makes the renderer a lot more reliable because of the forced requirement of a wrapper around any LWJGL 3 APIs which the mod wants to use.

Related Issue(s)

N/A

Checklist

  • I made a clear description of what was changed
  • I stated why these changes were necessary
  • I updated documentation or said what needs to be updated
  • I made sure these changes are backwards compatible
  • This pull request is for one feature/bug fix

@Deftu Deftu added enhancement New feature or request dependencies Pull requests that update a dependency file major impact Impact significantly affects the functionality labels Oct 10, 2024
@Deftu Deftu self-assigned this Oct 10, 2024
@Deftu Deftu changed the title Get the renderer into a semi-usable state. Isolate LWJGL 3 into it's own class loader and redo renderer to support it Oct 10, 2024
@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
OneConfig :modules:dependencies:legacy build 8.10 ❌ Build Scan published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
OneConfig :modules:dependencies:legacy build 8.10 ❌ Build Scan published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
OneConfig :modules:dependencies:legacy build 8.10 ❌ Build Scan published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
OneConfig :modules:dependencies:legacy build 8.10 ❌ Build Scan published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
OneConfig :modules:dependencies:legacy build 8.10 ❌ Build Scan published

@GerritsenParkway
Copy link

all i've seen in this commit are build failures and disappointment
i wish you all the best in making this happen

@Wyvest
Copy link
Member

Wyvest commented Oct 16, 2024

all i've seen in this commit are build failures and disappointment i wish you all the best in making this happen

It’s our buildscript it actually builds 💀💀💀

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
OneConfig :modules:dependencies:legacy build 8.10 ❌ Build Scan published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
OneConfig :modules:dependencies:legacy build 8.10 ❌ Build Scan published

@Wyvest Wyvest changed the title Isolate LWJGL 3 into it's own class loader and redo renderer to support it Isolate LWJGL3 and redo renderer Oct 20, 2024
@Wyvest Wyvest merged commit 77b1a77 into v1 Oct 20, 2024
2 of 4 checks passed
@Wyvest Wyvest deleted the isolated-lwjgl3 branch October 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Deftu Deftu

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request major impact Impact significantly affects the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deftu @GerritsenParkway @Wyvest