Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a basic description of special ERB tags #42

Merged
merged 3 commits into from
Dec 27, 2014

Conversation

ramya-n
Copy link
Contributor

@ramya-n ramya-n commented Dec 13, 2014

This is my very first pull request!

Should address the issue: #25, but is not quite ready to go yet.
Feel free to review :)

Done during the Codebar.io 24pullrequests special today.

With help from @fanaugen

<h2 id="rails-erb">ERB: Embedded Ruby</h2>
<p>
In your views (that is, under <code>app/views</code> in your Rails app) you will find
.html.erb files. <strong>ERB</strong> stands for <b>E</b>mbedded <b>Ruby</b>.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to stick to <strong> here as opposed to <b> all the way through :)

@PragTob
Copy link
Owner

PragTob commented Dec 16, 2014

Thanks a lot for the work!!! =)

Looks really good, just some minor comments

@ramya-n
Copy link
Contributor Author

ramya-n commented Dec 19, 2014

Hi Tobias,

Thank you for letting me know about these, I just missed to update

tag, I shall change it to , I understand you want to keep it consistent :)
Kind Regards,
Ramya

@PragTob
Copy link
Owner

PragTob commented Dec 20, 2014

Hi, thanks a lot!

Only thing missing now is the description of <% %> - do you want to tackle that or shall I?

@ramya-n
Copy link
Contributor Author

ramya-n commented Dec 22, 2014

Hi Tobias,

Thank you, I have updated the changes,
Please let me know if you require any other changes,

Kind Regards,
Ramya


From: Tobias Pfeiffermailto:[email protected]
Sent: ‎20/‎12/‎2014 12:04
To: PragTob/rails-beginner-cheatsheetmailto:[email protected]
Cc: Ramyamailto:[email protected]
Subject: Re: [rails-beginner-cheatsheet] [WIP] Add a basic description of special ERB tags (#42)

Hi, thanks a lot!

Only thing missing now is the description of <% %> - do you want to tackle that or shall I?


Reply to this email directly or view it on GitHub:
#42 (comment)

@PragTob
Copy link
Owner

PragTob commented Dec 27, 2014

Hi there, unfortunately that description isn't right - I'll fix it up. Thanks for the contribution!

@PragTob PragTob merged commit 4749e6b into PragTob:gh-pages Dec 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants