-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legacy id:meta to block state map #755
Conversation
Where did your source this data from? |
The schema is also not correct, it should be encapsulated inside a blocks object like the pc legacy.json. That will allow it to be added here https://github.com/PrismarineJS/node-minecraft-data/blob/master/index.js#L109 and used like doc in https://github.com/PrismarineJS/node-minecraft-data/blob/master/doc/api.md#minecraftdatalegacypcblocks |
Good question, it's based on:
Would that still be okay? I don't include the |
Yes, I mean you would need to fix that. I don't see how it makes sense to do special handling inside node-minecraft-data over just fixing the schema here to match the existing one. |
The items section will be a future problem
OK, and to be clear this is only mapping 1.2 (pre-flattening) -> and 1.3/1.4 (post-flattening) right? |
I generated the data with |
Merged, you can open an accompanying PR to node-minecraft-data to expose the new data by adding bedrock to here: https://github.com/PrismarineJS/node-minecraft-data/blob/master/index.js#L109 Additionally, we may need additional mapping here per PrismarineJS/prismarine-chunk#230 that blocks may have been renamed after flattening stringification in other versions. However, this can be investigated later on what the optimal way to handle this is. |
/makerelease |
This has been auto-generated.