Update libcompiler_rt to LLVM 10 and simplify the versioning limits macros #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes using the x86_64 sources instead of the generic sources, alongside adding ___chkstk_darwin to compiler-rt's symbols, therefore making it compatible with Darwin 19, I believe. I also removed a lot of unused files, specifically functions that I didn't see available in /usr/lib/system/libcompiler_rt.dylib
Zormeister
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically makes
libcompiler_rt.dyliba perfect replica of the library used in macOS Catalina (Darwin 19.6), as it re-exports___chkstk_darwinfrom libpthread, alongside removing any unused pieces of compiler-rt in the process.The only difference I’ve found is that it includes the 128-bit atomic operations (Tested on a Monterey and Catalina host, both produced the same results), but that doesn’t seem like a cause for concern.