Fire the hashchange event even if the navigation changes only location.hash
#7329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
I am making an app with Qwik that is using SPA navigation between pages including URL fragment.
Currently, the SPA navigation doesn't fire the
hashchange
event if the change of URL is only the hash fragment because it is usinghistory.pushState
.This is not the standard behaviour of the browser.
So I have changed this
location.hash = ...
due to fire the hashchange event.Checklist
pnpm change