Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire the hashchange event even if the navigation changes only location.hash #7329

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

genki
Copy link
Contributor

@genki genki commented Feb 10, 2025

What is it?

  • Bug fix

Description

I am making an app with Qwik that is using SPA navigation between pages including URL fragment.
Currently, the SPA navigation doesn't fire the hashchange event if the change of URL is only the hash fragment because it is using history.pushState.
This is not the standard behaviour of the browser.

So I have changed this

  • only if the change is consist of the fragment of URL.
  • then navigate by using location.hash = ... due to fire the hashchange event.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@genki genki requested a review from a team as a code owner February 10, 2025 21:27
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: e2dd128

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 10, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7329
npm i https://pkg.pr.new/@builder.io/qwik-city@7329
npm i https://pkg.pr.new/eslint-plugin-qwik@7329
npm i https://pkg.pr.new/create-qwik@7329

commit: e2dd128

Copy link
Contributor

github-actions bot commented Feb 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview e2dd128

@JerryWu1234
Copy link
Contributor

it would be great if you add a test for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants