Codegen integration #3415
Codegen integration #3415
Conversation
…uped_conv_fwd_multiple_abd files from CK
| { | ||
| return false; | ||
| } | ||
| if(!(problem.IsLayoutNHWC() || problem.IsLayoutDefault())) |
There was a problem hiding this comment.
only nhwc is supported or both nhwc and nchw are supported? Just curious
There was a problem hiding this comment.
This example only supports nhwc
There was a problem hiding this comment.
so can we just do if(!(problem.IsLayoutNHWC())
requirements.txt
Outdated
| ROCm/composable_kernel@fb948120d2d674607e70d0e7587dcb249c0e74c7 -DCMAKE_BUILD_TYPE=Release | ||
| ROCm/composable_kernel@5574422afe4a357e1e5be60cc58ab42645553b93 -DCMAKE_BUILD_TYPE=Release |
There was a problem hiding this comment.
We will want to update this commit to match with CK next time it's promoted to staging I think, and same in the docker file.
There was a problem hiding this comment.
The PR from CK has been merged into develop. Before it gets merged into staging, we'll need to make one last check to make sure that version of CK is still hipRTC compatible. Then I can change the commit hash here to match
CMakeLists.txt
Outdated
| @@ -328,6 +328,8 @@ add_compile_definitions($<$<COMPILE_LANGUAGE:CXX>:HIP_COMPILER_FLAGS=${HIP_COMPI | |||
| # HIP | |||
| if( MIOPEN_BACKEND STREQUAL "HIP" OR MIOPEN_BACKEND STREQUAL "HIPOC" OR MIOPEN_BACKEND STREQUAL "HIPNOGPU") | |||
| if(MIOPEN_USE_COMPOSABLEKERNEL) | |||
| include(/usr/local/lib/cmake/composable_kernel_host/ck_host_targets.cmake) | |||
There was a problem hiding this comment.
Why is ck_host installed into a different location than the rest of the libs?
Also, do we need a separate include call here, or does find_package cover it since we have /usr/local/lib added to the prefix path?
There was a problem hiding this comment.
The ck_host lib is installed into a different location due to conflicting struct names with MIGraphX. We moved it from /opt/rocm/lib/ so they don't inadvertently access the ck_host lib if they didn't mean to.
src/solver/codegen_conv_hip_implicit_gemm_2d_grouped_fwd_xdlops.cpp
Outdated
Show resolved
Hide resolved
No description provided.