Prec param new #1813
Prec param new #1813
Conversation
aledudek
requested review from
junliume,
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca and
afagaj
as code owners
| if(t.data_type == "fp16") | ||
| { | ||
| return gemm_type_<GemmFp16>(t, args, s); | ||
| } | ||
| else if(t.data_type == "bf16") | ||
| { | ||
| return gemm_type_<GemmBf16>(t, args, s); | ||
| } | ||
| else | ||
| { | ||
| throw std::runtime_error("Wrong! Data type not supported!\n"); | ||
| } |
There was a problem hiding this comment.
We should have also support for fp8. Take a look in here:
composable_kernel/include/ck_tile/ops/gemm/warp/warp_gemm.hpp
Lines 125 to 158 in 3de7bd6
| struct GemmBf16 | ||
| { | ||
| }; | ||
|
|
||
| template <typename DataType> | ||
| struct GemmBasicTypeConfig; |
There was a problem hiding this comment.
Please rename this structure to GemmTypeConfig.
There was a problem hiding this comment.
This file should be renamed to gemm.hpp - this is our GEMM host API definition.
| struct GemmFp16 | ||
| { | ||
| }; | ||
|
|
||
| struct GemmBf16 | ||
| { | ||
| }; |
There was a problem hiding this comment.
What about just enumerator class ?
| template <typename DataType> | ||
| struct GemmBasicTypeConfig; |
There was a problem hiding this comment.
Please add documentation. Describe what this class defines ( supported data type configurations).
There was a problem hiding this comment.
This is awkward. You repeat GemmBasicTypeConfig in every function... Why not just pass type string and layouts as strings ? We should manage this inside our host API and do not repeat the same logic at every step.
Proposed changes
Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered