Skip to content

Commit

Permalink
[release/2.3] skip test_pattern_matcher on Navi (#1864)
Browse files Browse the repository at this point in the history
skip
`dynamo/test_activation_checkpointing.py::ActivationCheckpointingViaTagsTests::test_pattern_matcher`
on Navi in release/2.3

Fixes SWDEV-481719
  • Loading branch information
dnikolaev-amd authored Feb 4, 2025
1 parent a7b07f9 commit 6d6d0e5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/dynamo/test_activation_checkpointing.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from torch._dynamo.backends.common import aot_autograd
from torch._dynamo.testing import CompileCounterWithBackend
from torch._higher_order_ops.wrap import tag_activation_checkpoint
from torch.testing._internal.common_utils import IS_WINDOWS, skipIfRocm
from torch.testing._internal.common_utils import IS_WINDOWS, NAVI_ARCH, skipIfRocm, skipIfRocmArch
from torch.testing._internal.inductor_utils import HAS_CUDA
from torch.testing._internal.two_tensor import TwoTensor
from torch.utils.checkpoint import _pt2_selective_checkpoint_context_fn_gen, checkpoint
Expand Down Expand Up @@ -1014,6 +1014,7 @@ def fn(x, ys):
self.assertEqual(ref, res)

@requires_cuda
@skipIfRocmArch(NAVI_ARCH) # failed on Navi 2x, 3x, 4x
def test_pattern_matcher(self):
# Check that the sdpa op is recomputed in the backward graph
# tests percolate_tags
Expand Down
1 change: 1 addition & 0 deletions torch/testing/_internal/common_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@

from .composite_compliance import no_dispatch

NAVI_ARCH = ("gfx1030", "gfx1100", "gfx1101", "gfx1200", "gfx1201")

# Class to keep track of test flags configurable by environment variables.
# Flags set here are intended to be read-only and should not be modified after
Expand Down

0 comments on commit 6d6d0e5

Please sign in to comment.