Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.3] skip test_pattern_matcher on Navi #1864

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[release/2.3] skip test_pattern_matcher on Navi #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
208a17a
[release/2.3] skip test_pattern_matcher on Navi
dnikolaev-amd Jan 29, 2025
29483d0
Update test_activation_checkpointing.py
dnikolaev-amd Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/dynamo/test_activation_checkpointing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from torch._dynamo.backends.common import aot_autograd
from torch._dynamo.testing import CompileCounterWithBackend
from torch._higher_order_ops.wrap import tag_activation_checkpoint
from torch.testing._internal.common_utils import IS_WINDOWS, skipIfRocm
from torch.testing._internal.common_utils import IS_WINDOWS, NAVI_ARCH, skipIfRocm, skipIfRocmArch
from torch.testing._internal.inductor_utils import HAS_CUDA
from torch.testing._internal.two_tensor import TwoTensor
from torch.utils.checkpoint import _pt2_selective_checkpoint_context_fn_gen, checkpoint
Expand Down Expand Up @@ -1014,6 +1014,7 @@ def fn(x, ys):
self.assertEqual(ref, res)

@requires_cuda
@skipIfRocmArch(NAVI_ARCH) # failed on Navi 2x, 3x, 4x
def test_pattern_matcher(self):
# Check that the sdpa op is recomputed in the backward graph
# tests percolate_tags
Expand Down
1 change: 1 addition & 0 deletions torch/testing/_internal/common_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@

from .composite_compliance import no_dispatch

NAVI_ARCH = ("gfx1030", "gfx1100", "gfx1101", "gfx1200", "gfx1201")

# Class to keep track of test flags configurable by environment variables.
# Flags set here are intended to be read-only and should not be modified after
Expand Down