Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Signalling Operations Functional Test #34

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Yiltan
Copy link
Contributor

@Yiltan Yiltan commented Feb 4, 2025

Fixes a bug where: rocshmem_signal_fetch_wave is called on the global context but we would wait on a private context rocshmem_ctx_quiet(ctx);

  • Split existing kernel into two tests that evaluate:
    1. rocshmem_ctx_putmem_signal*
    2. rocshmem_signal_fetch*

- Ensure quiet is called on the correct context
@Yiltan
Copy link
Contributor Author

Yiltan commented Feb 6, 2025

@avinashkethineedi The requested updates to the putmem_signal tests should now be present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants