Skip to content

Commit

Permalink
feat: add v23 support
Browse files Browse the repository at this point in the history
Fixes: #270
  • Loading branch information
RafaelGSS committed Oct 29, 2024
1 parent 4a90b4b commit 7891c93
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
node-versions:
required: true
type: string
default: '["18.0.0","18.20.3","18.20.4","20.0.0","20.16.0","20.17.0","21.0.0","21.7.2","21.7.3","22.0.0","22.6.0","22.7.0"]'
default: '["18.0.0","18.20.0","18.20.4","20.0.0","20.17.0","20.18.0","21.0.0","21.7.3","22.0.0","22.9.0","22.11.0", "23.0.0"]'
description: 'The Node.js Versions (should be a JSON array)'
node-opts:
required: false
Expand Down Expand Up @@ -171,10 +171,10 @@ jobs:
with:
ref: ${{ github.ref }}

- name: Use Node.js v20.x
- name: Use Node.js v22.x
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.x

- name: Create temporary report folder
run: mkdir ./temp-reports
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check_regressions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
versions:
required: true
type: string
default: 'v18,v20,v21,v22'
default: 'v18,v20,v21,v22,v23'
description: 'The Node.js Versions (the folder must exist)'
major-only:
required: true
Expand All @@ -23,7 +23,7 @@ jobs:
- name: Use Node.js v${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: 'v20.x'
node-version: 'v22.x'

- name: NPM Install
run: npm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
node-versions:
required: true
type: string
default: '["18.0.0","18.20.3","18.20.4","20.0.0","20.16.0","20.17.0","21.0.0","21.7.2","21.7.3","22.0.0","22.8.0","22.9.0"]'
default: '["18.0.0","18.20.3","18.20.4","20.0.0","20.17.0","20.18.0","21.0.0","21.7.2","21.7.3","22.0.0","22.10.0","22.11.0","23.0.0","23.1.0"]'
description: 'The Node.js Versions (should be a JSON array)'

permissions:
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,15 @@ All the benchmarks are stored in `RESULTS-{Node-Version}.md`
- [v20](./RESULTS-v20.md)
- [v21](./RESULTS-v21.md)
- [v22](./RESULTS-v22.md)
- [v23](./RESULTS-v23.md)

It also stores the last 3 versions of each active release line. You can check it inside its respective folder:

- [v18](./v18)
- [v20](./v20)
- [v21](./v21)
- [v22](./v22)
- [v23](./v23)

This is useful to identify regressions in minor/patch versions.

Expand Down
2 changes: 1 addition & 1 deletion scripts/generate-run-all.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const benchJobs = allBenches.map((benchFile, index, array) => {
`;
});

const MAJORS = [18, 20, 21, 22];
const MAJORS = [18, 20, 21, 22, 23];
const nodeVersions = []
const allVersions = await nv('all');
for (const m of MAJORS) {
Expand Down
Empty file added v23/.gitkeep
Empty file.

0 comments on commit 7891c93

Please sign in to comment.