Added TODOs and local pgbench results. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, that seems quite helpful.
By default it only tracks timing for queries with execution times greater than 1000 ms, needs to configure via min_duration |
CyberDem0n
reviewed
Jun 26, 2020
| @@ -439,13 +439,13 @@ pgmon_save_firsttuple(QueryDesc *queryDesc) | |||
| static void | |||
| pgmon_plan_store(QueryDesc *queryDesc) | |||
| { | |||
| Assert(queryDesc != NULL); | |||
There was a problem hiding this comment.
It is illegal in C to have a variable declaration not at the beginning of code block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some TODOs we should walk through together.
Also added results from local pgbench vs pg12 on ubuntu 20.04. Scale factor 100.
There seems to be issues with tracking the timing, that part remains empty.