-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for NET 9 SDK analysis #1743
Conversation
@lahma can you maybe also add a fix for this windows CI build failure (conflict)? |
Sure, gimme an hour so that I get back to computer, I've dealt with this before. |
0bcc49e
to
00cd693
Compare
00cd693
to
5b3aa51
Compare
@RicoSuter should now publish only on Windows (this changed with v4 actions and they will error if multiple jobs try to do it), also brought back merge-conflicted analysis fixes. |
Thanks for the fix, can we merge this PR then? |
Can be merged. This is not needed for NSwag, but if you want to compile with NET 9 SDK (global.json now only allows 8.0) there would be compile errors, after this, no more. I can create a separate PR to switch to NET 9 SDK or add is as part of this too. |
Yes please update PR to use .NET 9 then... |
Changes are cosmetic, done with IDE auto fixes (Rirder, but I believe these are Roslyn based). |
9756500
to
f510062
Compare
@RicoSuter now uses (and requires) NET 9 SDK when building. |
NET 9 SDK has more rules and will cause build problems. Creating a TODO list for focused PRs in
Directory.Build.props
viaNoWarn
items, fixing small easy wins inside the PR. Now compiles with NET 9 SDK. All changes made with IDE automation.