Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for NET 9 SDK analysis #1743

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Nov 19, 2024

NET 9 SDK has more rules and will cause build problems. Creating a TODO list for focused PRs in Directory.Build.props via NoWarn items, fixing small easy wins inside the PR. Now compiles with NET 9 SDK. All changes made with IDE automation.

@RicoSuter
Copy link
Owner

RicoSuter commented Nov 19, 2024

@lahma can you maybe also add a fix for this windows CI build failure (conflict)?

image

https://github.com/RicoSuter/NJsonSchema/actions

@lahma
Copy link
Collaborator Author

lahma commented Nov 19, 2024

Sure, gimme an hour so that I get back to computer, I've dealt with this before.

@lahma lahma force-pushed the net-9-sdk-analysis branch from 0bcc49e to 00cd693 Compare November 19, 2024 14:56
@lahma lahma force-pushed the net-9-sdk-analysis branch from 00cd693 to 5b3aa51 Compare November 19, 2024 14:57
@lahma
Copy link
Collaborator Author

lahma commented Nov 19, 2024

@RicoSuter should now publish only on Windows (this changed with v4 actions and they will error if multiple jobs try to do it), also brought back merge-conflicted analysis fixes.

@RicoSuter
Copy link
Owner

Thanks for the fix, can we merge this PR then?
Is this necessary for new NSwag release or can this also wait?

@lahma
Copy link
Collaborator Author

lahma commented Nov 19, 2024

Can be merged. This is not needed for NSwag, but if you want to compile with NET 9 SDK (global.json now only allows 8.0) there would be compile errors, after this, no more. I can create a separate PR to switch to NET 9 SDK or add is as part of this too.

@RicoSuter
Copy link
Owner

Can be merged. This is not needed for NSwag, but if you want to compile with NET 9 SDK (global.json now only allows 8.0) there would be compile errors, after this, no more. I can create a separate PR to switch to NET 9 SDK or add is as part of this too.

Yes please update PR to use .NET 9 then...
So the changes are "cosmetic" only right?

@lahma
Copy link
Collaborator Author

lahma commented Nov 19, 2024

Can be merged. This is not needed for NSwag, but if you want to compile with NET 9 SDK (global.json now only allows 8.0) there would be compile errors, after this, no more. I can create a separate PR to switch to NET 9 SDK or add is as part of this too.

Yes please update PR to use .NET 9 then... So the changes are "cosmetic" only right?

Changes are cosmetic, done with IDE auto fixes (Rirder, but I believe these are Roslyn based).

@lahma lahma force-pushed the net-9-sdk-analysis branch from 9756500 to f510062 Compare November 19, 2024 15:16
@lahma
Copy link
Collaborator Author

lahma commented Nov 19, 2024

@RicoSuter now uses (and requires) NET 9 SDK when building.

@RicoSuter RicoSuter merged commit 2333d39 into RicoSuter:master Nov 19, 2024
2 checks passed
@lahma lahma deleted the net-9-sdk-analysis branch November 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants