Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with uint8[] as binary data not string #1006

Draft
wants to merge 2 commits into
base: ros2
Choose a base branch
from
Draft

Deal with uint8[] as binary data not string #1006

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73bbd04
Deal with uint8[] as binary data not string
alien19 Feb 6, 2025
0864706
Merge branch 'ros2' into ros2
alien19 Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rosbridge_library/src/rosbridge_library/internal/message_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,10 @@ def msg_class_type_repr(msg_class):

def _from_inst(inst, rostype):
global bson_only_mode
# Special case for uint8[], we encode the string
# Special case for uint8[]
for binary_type, expression in ros_binary_types_list_braces:
if expression.sub(binary_type, rostype) in ros_binary_types:
encoded = get_encoder()(inst)
return encoded.decode("ascii")
return inst

# Check for time or duration
if rostype in ros_time_types:
Expand Down
Loading