SapMachine #1901: Feature Request to allow service to crash if direct memory is OOM #1916
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect memory is OOM
|
Hello @ansteiner, this pull request fulfills all formal requirements. |
MBaesken
reviewed
Feb 6, 2025
src/hotspot/share/prims/unsafe.cpp
Outdated
| @@ -478,6 +478,12 @@ UNSAFE_LEAF (void, Unsafe_WriteBackPostSync0(JNIEnv *env, jobject unsafe)) { | |||
| doWriteBackSync0(false); | |||
| } UNSAFE_END | |||
|
|
|||
| // SapMachine 2025-02-05: Report error for DirectByteBufferOom to exit the VM | |||
| UNSAFE_LEAF (void, Unsafe_ReportJavaOutOfMemory0(JNIEnv *env, jobject unsafe,jstring message)) { | |||
| char *utf_message = java_lang_String::as_utf8_string(JNIHandles::resolve_non_null(message)); | |||
There was a problem hiding this comment.
On other usage of java_lang_String::as_utf8_string I see a ResourceMark usage, seems this is missing here.
MBaesken
reviewed
Feb 6, 2025
MBaesken
reviewed
Feb 6, 2025
test/hotspot/jtreg/runtime/ErrorHandling/TestExitOnDirectOutOfMemoryError.java
Outdated
Show resolved
Hide resolved
MBaesken
reviewed
Feb 6, 2025
test/hotspot/jtreg/runtime/ErrorHandling/TestExitOnDirectOutOfMemoryError.java
Outdated
Show resolved
Hide resolved
RealCLanger
requested changes
Feb 6, 2025
|
Hello @ansteiner, this pull request fulfills all formal requirements. |
|
Hello @ansteiner, this pull request fulfills all formal requirements. |
|
OK, we need to figure out what happens in the test. |
| @@ -478,6 +478,12 @@ UNSAFE_LEAF (void, Unsafe_WriteBackPostSync0(JNIEnv *env, jobject unsafe)) { | |||
| doWriteBackSync0(false); | |||
| } UNSAFE_END | |||
|
|
|||
| // SapMachine 2025-02-05: Report error for DirectMemoryOom to exit the VM | |||
| UNSAFE_LEAF (void, Unsafe_ReportJavaOutOfMemory0(JNIEnv *env, jobject unsafe, jstring message)) { | |||
There was a problem hiding this comment.
This should be UNSAFE_ENTRY instead of UNSAFE_LEAF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the direct memory buffer run into OOM, DirectByteBuffer allocation code can notify the jvm if the system property "jdk.nio.reportErrorOnDirectMemoryOom" is set.
Benefits:
Crash/ExitOnOutOfMemoryErrorallows a app/JVM that can no longer provide services and application code is handling the OOM of DirectByteBuffer to crash/exit and enabling the service to restart.HeapDumpOnOutOfMemoryErroroption.Implementation with some minor adaptions from closed issue/PR from OpenJDK: openjdk/jdk#16176
fixes #1901