Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: ファイル上限の明記 #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Shimiiy
Copy link
Member

@Shimiiy Shimiiy commented May 23, 2023

概要

  • 依存関係の更新(yarn.lock)
  • ファイル上限(100MB)の明記

スクリーンショット(変更の場合は変更前と変更後が分かるように)

変更前
Image Pasted at 2023-5-24 00-04
変更後
Image Pasted at 2023-5-24 00-13

破壊的変更があるか(あれば内容を記載)

  • YES
  • NO

チェック項目

  • ビルドが通る
  • 作成した機能が想定通りに動作する
  • スマートフォンサイズで表示確認を行った
  • ダークモードで表示確認を行った
  • warning が増えていない
  • 複雑なコードにはコメントを記載してある

@Shimiiy Shimiiy added the 改善 label May 23, 2023
@Shimiiy Shimiiy requested a review from MogamiTsuchikawa May 23, 2023 15:18
@Shimiiy Shimiiy self-assigned this May 23, 2023
@@ -74,6 +74,7 @@ export const FileUploader = ({ open, onCancel, onUploaded, onlyFileKind }: FileU
<Modal open={isOpen}>
<Box sx={style}>
<h2>ファイルアップロード</h2>
<Alert severity="info">ファイル上限: 100MBまで</Alert>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timesで話したとおり、marginちょっとつけてほしい...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants