SQLite update DDL creation to the new db enum #1120
Conversation
Sildra
force-pushed
the
sqlite-ddl
branch
2 times, most recently
from
ea33624 to
261a02f
Compare
|
Sorry, could you please explain what does this actually change? |
|
It is the PR that resolves #1085 |
There was a problem hiding this comment.
Sorry but the test code is very difficult to understand as written: it has no comments and uses unclear or even misleading names. Could you please simplify it to make it actually understandable?
As for the changes themselves, I'm not sure at all about the date type, but otherwise I think they should do no harm. I'd appreciate opinion of the other SQLite users however.
Sildra
force-pushed
the
sqlite-ddl
branch
4 times, most recently
from
a4766f1 to
3b9b24f
Compare
|
Hello, any news about improving the table creation with the DDL interface ? Regards, |
tests/common-tests.h
Outdated
| } | ||
|
|
||
| template<typename T> | ||
| void test_roundtrip(soci::session &sql, Roundtrip<T>&& tester) |
There was a problem hiding this comment.
Why is tester passed as r-value reference, it doesn't seem to be consumed by this function? Or is it? A comment would be nice...
FWIW I'd probably just pass db_type (unless it can be deduced from T?) and the value directly here.
There was a problem hiding this comment.
Will do this, it will solve the r-value ref.
There was a problem hiding this comment.
db_type could be deduced from T but it would require defining templates for this and it would add a lot of code.
| @@ -287,9 +287,89 @@ template<> struct type_conversion<PhonebookEntry3> | |||
| ind = i_ok; | |||
| } | |||
| }; | |||
| } // namespace soci | |||
|
|
|||
| template<typename T> | |||
There was a problem hiding this comment.
A comment explaining what is this type used for would be nice to have.
|
Thanks, merged now with minor stylistic corrections. |
No description provided.