Add UBSAN build option and fix building using it #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though this didn't any harm in practice, it's still undefined behaviour and should be avoided.
This ensures that they are initialized, which previously wasn't the case, e.g. gotData_ wasn't initialized in the default ctor and poolPosition_ wasn't initialized at all. This didn't seem to result in any real problems, but triggered UBSAN reports when copying "bool gotData_" values which didn't have a valid value for bool type.
Export all backend classes as they can be used in the application code, and some of them were actually used in our own tests (and, also, some of them had been already exported, even though most were not, so exporting all of them is also more consistent). Also export ref_counted_prepare_info and ref_counted_statement classes to make their type info information accessible from outside the library: this is needed at least when UBSAN and, more precisely, its vtbl sanitizer, is used, as it uses typeinfo. Closes SOCI#1103.
Allow to easily enable UBSAN. Don't bother to test for the compiler versions, assume that when someone enables it, they have compiler support for it.
UBSAN gives nonsensical errors for the ODBC job running under Ubuntu 18.04, e.g. it complains that src/core/session.cpp:246:16: runtime error: member call on address 0x607000000250 which does not point to an object of type 'session_backend' 1: 0x607000000250: note: object is of type 'soci::odbc_session_backend' which doesn't make any sense because odbc_session_backend is an object of type session_backend. But apparently something is broken in this compiler version, so disable UBSAN for this job for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.