Simplify affected rows handling in PostgreSQL backend #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to test if rowsAffectedBulk_ is positive before returning it, as we return -1 otherwise anyhow -- so we can just as well return it directly. No real changes.
This is just a tiny simplification, no real changes.
Just use rowsAffectedBulk_ normally, there doesn't seem to be any need for this temporary variable and using it is fragile as it's easy to forget to copy it into rowsAffectedBulk_ itself before returning. This is similar to what was done in 42d5a2e (Fix get_affected_rows() for partial updates in SQLite3 backend, 2025-01-28) for SQLite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No real changes, just more cleanup.