Code

Splitattrs ncsave redo#5410

Code

Merged

trexfeathers merged 38 commits intoSciTools:FEATURE_split_attrsSciTools/iris:FEATURE_split_attrsfrom pp-mo:splitattrs_ncsave_redopp-mo/iris:splitattrs_ncsave_redoCopy head branch name to clipboardOct 10, 2023

+4,283-530

Commits

Commits on Jul 28, 2023

• Add docs and future switch, no function yet.

  pp-mo

  committed
  83eee13

  Copy full SHA for 83eee13

Commits on Jul 30, 2023

• Typing enables code completion for Cube.attributes.

  pp-mo

  committed
  ce5cdef

  Copy full SHA for ce5cdef

Commits on Aug 1, 2023

• Make roundtrip checking more precise + improve some tests accordingly (cf. SciTools#5403).

  pp-mo

  committed
  4d660b6

  Copy full SHA for 4d660b6

Commits on Aug 2, 2023

• Rework all tests to use common setup + results-checking code.

  pp-mo

  committed
  9a80cd2

  Copy full SHA for 9a80cd2

• Saver supports split-attributes saving (no tests yet).

  pp-mo

  committed
  4ecef96

  Copy full SHA for 4ecef96

• Tiny docs fix.

  pp-mo

  committed
  78aaebb

  Copy full SHA for 78aaebb

Commits on Aug 3, 2023

• Explain test routines better.

  pp-mo

  committed
  54f344c

  Copy full SHA for 54f344c

• Fix init of FUTURE object.

  pp-mo

  committed
  edc9899

  Copy full SHA for edc9899

• Remove spurious re-test of FUTURE.save_split_attrs.

  pp-mo

  committed
  d242506

  Copy full SHA for d242506

Commits on Aug 4, 2023

• Don't create Cube attrs of 'None' (n.b. but no effect as currently used).

  pp-mo

  committed
  8d7ad2a

  Copy full SHA for 8d7ad2a

• Remove/repair refs to obsolete routines.

  pp-mo

  committed
  8aa5311

  Copy full SHA for 8aa5311

• Check all warnings from save operations.

  pp-mo

  committed
  f87550b

  Copy full SHA for f87550b

• Remove TestSave test numbers.

  pp-mo

  committed
  30d62c2

  Copy full SHA for 30d62c2

• More save cases: no match with missing, and different cube attribute types.

  pp-mo

  committed
  fb13770

  Copy full SHA for fb13770

Commits on Aug 6, 2023

• Run save/roundtrip tests both with+without split saves.

  pp-mo

  committed
  5a429d0

  Copy full SHA for 5a429d0

• Fix.

  pp-mo

  committed
  dd53275

  Copy full SHA for dd53275

Commits on Aug 7, 2023

• Review changes.

  pp-mo

  committed
  80a4039

  Copy full SHA for 80a4039

Commits on Aug 8, 2023

• Fix changed warning messages.

  pp-mo

  committed
  fb343ae

  Copy full SHA for fb343ae

• Move warnings checking from 'run' to 'check' phase.

  pp-mo

  committed
  b1778c6

  Copy full SHA for b1778c6

• Simplify and improve warnings checking code.

  pp-mo

  committed
  067f07d

  Copy full SHA for 067f07d

• Fix wrong testcase.

  pp-mo

  committed
  891da48

  Copy full SHA for 891da48

• Minor review changes.

  pp-mo

  committed
  8ecadca

  Copy full SHA for 8ecadca

• Fix reverted code.

  pp-mo

  committed
  4edf778

  Copy full SHA for 4edf778

• Use sets to simplify demoted-attributes code.

  pp-mo

  committed
  159914c

  Copy full SHA for 159914c

Commits on Aug 18, 2023

• WIP

  pp-mo

  committed
  deb1db3

  Copy full SHA for deb1db3

• Working with iris 3.6.1, no errors TestSave or TestRoundtrip.

  pp-mo

  committed
  e5d5ff9

  Copy full SHA for e5d5ff9

Commits on Aug 21, 2023

• Interim save (incomplete?).

  pp-mo

  committed
  42fce92

  Copy full SHA for 42fce92

• Different results form for split tests; working for roundtrip.

  pp-mo

  committed
  19a2956

  Copy full SHA for 19a2956

• Check that all param lists are sorted.

  pp-mo

  committed
  59d05dc

  Copy full SHA for 59d05dc

• Check matrix result-files compatibility; add test_save_matrix.

  pp-mo

  committed
  1770d97

  Copy full SHA for 1770d97

• test_load_matrix added; two types of load result.

  pp-mo

  committed
  b67f510

  Copy full SHA for b67f510

• Finalise special-case attributes.

  pp-mo

  committed
  2576826

  Copy full SHA for 2576826

• Small docs tweaks.

  pp-mo

  committed
  e201a8e

  Copy full SHA for e201a8e

• Add some more testcases,

  pp-mo

  committed
  4602f06

  Copy full SHA for 4602f06

• Ensure valid sort-order for globals of possibly different types.

  pp-mo

  committed
  2377c89

  Copy full SHA for 2377c89

• Initialise matrix results with legacy values from v3.6.1 -- all matching.

  pp-mo

  committed
  8987a26

  Copy full SHA for 8987a26

• Add full current matrix results, i.e. snapshot current behaviours.

  pp-mo

  committed
  cbd7167

  Copy full SHA for cbd7167

Commits on Oct 10, 2023

• Review changes : rename some matrix testcases, for clarity.

  pp-mo

  committed
  eea99d1

  Copy full SHA for eea99d1