Skip to content

Commit

Permalink
[grid] Grid UI could not open session live view (#15132)
Browse files Browse the repository at this point in the history
* [grid] Grid UI could not open session live view

* Bump version 4.28.1 for java and update changelog

---------

Signed-off-by: Viet Nguyen Duc <[email protected]>
  • Loading branch information
VietND96 authored Jan 23, 2025
1 parent 43c6e35 commit 57c989c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions java/CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
v4.28.1
======
* [java]: Add Locale.ROOT to avoid port formatting issues for all drivers (#15121)
* [grid]: Grid UI could not open session live view (#15132)

v4.28.0
======
* Add CDP for Chrome 132 and remove 129
Expand Down
2 changes: 1 addition & 1 deletion java/version.bzl
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
SE_VERSION = "4.29.0-SNAPSHOT"
SE_VERSION = "4.28.1"
TOOLS_JAVA_VERSION = "17"
3 changes: 2 additions & 1 deletion javascript/grid-ui/src/components/LiveView/LiveView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,13 @@ const LiveView = forwardRef((props, ref) => {
return
}

const newRfb = new RFB(canvas, props.url, {})
const newRfb = new RFB.default(canvas, props.url, {})
newRfb.scaleViewport = props.scaleViewport
newRfb.background = 'rgb(247,248,248)'
newRfb.addEventListener('credentialsrequired', handleCredentials)
newRfb.addEventListener('securityfailure', securityFailed)
newRfb.addEventListener('connect', connectedToServer)
newRfb.addEventListener('disconnect', disconnect)
setRfb(newRfb)
}

Expand Down

0 comments on commit 57c989c

Please sign in to comment.