-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callbacks for interval change and FRC request #49
base: master
Are you sure you want to change the base?
Callbacks for interval change and FRC request #49
Conversation
Hello @Heiko-L |
Now I reconsidered a bit and think that I keep my hands off the constructor and add callback functionality externally to keep compatibility. |
Your new approach would indeed be better IMO. Concerning the "paperwork": Q. |
I added SCDDataProvider (derived from DataProvider) and SCD4xDataProvider (derived from SCDDataProvider). |
Should I open another PR and close this one? |
Updating the code in this one would work as well but for now I do not see you new proposal |
I don't know how to do it. First I have to revert the two commits I have already done? |
If you are not comfortable with how to do it, the easiest is to close the PR and open a new one Cheers |
Instead of polling for FRC request there is now an option to register a callback function which is called on request.
Furthermore an option for a callback function on interval change is given.