Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows aren't reobfuscated on next gradle build after not changing any source files #9

Open
Barteks2x opened this issue Oct 2, 2018 · 6 comments

Comments

@Barteks2x
Copy link

I'm not sure which exact task being skipped causes it, but it's definitely not nice. I have to run clean build every time I want to build the mod and to someone who doesn't know that, it's not at all obvious. And the error in obfuscated environment is even more unobvious than in the previous issue with refmap.

@Pokechu22
Copy link

Which gradle version (since I think something with a task being skipped might depend on it since the new ones have been focusing on incremental compilation)?

@Barteks2x
Copy link
Author

Barteks2x commented Oct 2, 2018

I do use a pretty recent gradle version, currently not yet updated from some early nightly build of 4.10. I use that version because this was one of the first versions that supported snapshot plugin versions to be used with new plugins { } syntax, which allows kotlin-dsl to automatically generate all the accessors. I can't easily re-test on older gradle version, but I remember this issue being there for a long time, long before even 4.8.

@gabizou
Copy link
Member

gabizou commented Oct 2, 2018

I'm fairly sure that there have been some Gradle backwards compatibility issues for MixinGradle, leading to Sponge even using Gradle 3.3 for it's wrapper. I can't say for sure that's the leading cause, but you could give that a shot with old groovy plugins, otherwise, it's a matter of waiting for MixinGradle updating for newer versions of Gradle.

@Barteks2x
Copy link
Author

Barteks2x commented Oct 2, 2018

Unfortunately I would have to rewrite pretty much the whole buildscript to go back to gradle 3.x. Going forwards is much easier as the buildscript can be modified incrementally to use new features, and old ones still work.

@Pokechu22
Copy link

This issue still affects 0.7-SNAPSHOT.

@surge541
Copy link

Will this issue ever be fixed? It's just started happening to me, meaning it's hard to share my mod as only about 20% of people can launch with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants