Make SplittingStrategy::Semantic require an encoder #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you didn't specify an encoder separately you'd get a runtime exception. It's now required at compile time instead. I was originally hoping to also set the default to JINA, but Rust doesn't support default values for fields, and it didn't seem like a good idea to set the default SplittingStrategy to Semantic in general.
|
This looks good. I will test it out and let you know. In the meantime, could you also resolve the conflicts that are there? |
# Conflicts: # python/src/config.rs # rust/src/lib.rs
|
Should be all fixed now, thanks for the heads up! |
akshayballal95
approved these changes
Feb 11, 2025
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you didn't specify an encoder separately you'd get a runtime exception. It's now required at compile time instead.
I was originally hoping to also set the default to Jina, but Rust doesn't support default values for fields and it didn't seem like a good idea to set the default SplittingStrategy to Semantic in general.