Update face auth socket #2

eshaibu · 2018-01-19T08:34:11Z

No description provided.

adamwardecki · 2018-04-30T09:59:51Z

src/create-collection.js

+    const awsRekognitionClass = new Rekognition(ctx.config);
+    const result = await awsRekognitionClass.createCollection(collectionId);
+    return response.json({ collectionArn: result.CollectionArn, statusCode: result.StatusCode });
+  } catch ({ ...errors }) {


it you are using everything from the response object, it can be simply

catch (error) { return response.json(error, 400); }

adamwardecki · 2018-04-30T10:01:23Z

src/delete-collection.js

-      }, 400);
-    });
+    const awsRekognitionClass = new Rekognition(ctx.config);
+    const result = await awsRekognitionClass.deleteCollection(collectionId);


const { statusCode } = await ...

adamwardecki · 2018-04-30T10:03:13Z

src/face-login.js

+    if (err.statusCode || err.code) {
+      return response.json(err, err.statusCode || 400);
+    }
+    return response.json({ message: 'Authentication fail.' }, 401);


s/fail/failed

adamwardecki · 2018-04-30T10:03:59Z

src/face-login.js

-    }
-    return res;
-  };
+    const result = await awsRekognitionClass.searchFacesByImage(collectionId, image, s3Bucket, faceMatchThreshold);


const { FaceMatches }

adamwardecki · 2018-04-30T10:16:24Z

src/face-register.js

+    try {
+      const faceIds = res.FaceRecords.map(record => record.Face.FaceId);
+      await awsRekognitionClass.deleteFaces(collectionId, faceIds);
+      return Promise.reject({ message, statusCode: 400 });


Promise.resolve ?

I want it in outer catch

adamwardecki · 2018-04-30T10:50:52Z

src/face-login.js

+      await users.where('external_image_id', result.FaceMatches[0].Face.ExternalImageId).firstOrFail();
+    return response.json({ token: user_key, username });
+  } catch (err) {
+    if (err.statusCode || err.code) {


the err.code is currently not being used in the response (same in face-register.js)

Sometime aws error response returns with no statusCode but always with code as part of error response

adamwardecki · 2018-04-30T10:56:40Z

src/remove-face-auth.js

+    if (searchFacesResult.FaceMatches.length > 0
+      && searchFacesResult.FaceMatches[0].Face.ExternalImageId === external_image_id) {
+      // delete the user faces index
+      if (searchFacesResult.FaceMatches.length > 0) {


searchFacesResult.FaceMatches.length > 0 was checked in line 37

adamwardecki · 2018-04-30T11:24:53Z

src/utils/Rekognition.js

@@ -87,7 +58,7 @@ class Rekognition {
    }
    try {
      return {
-        Bytes: await Rekognition.convertImageToBytes(image)
+        Bytes: await Buffer.from(image, 'base64')


adamwardecki · 2018-04-30T11:27:08Z

src/verify-face-auth.js

-    .firstOrFail()
-    .then(verifyUserFaceAuthRegistered)
-    .catch(() => {
+    if (result.user_key !== token) {
      return response.json({ message: 'Given credentials does not match any user account.' }, 401);


adamwardecki · 2018-04-30T11:27:53Z

src/verify-face-auth.js

-      message: 'Face auth enabled on user account.', is_face_auth: true
-    });
-  };
+    const result = await users.where('username', username).firstOrFail();


const { user_key, face_auth } = await

eshaibu added 2 commits January 18, 2018 12:57

create and delete collection only accessible if valid keys supplied

0384be6

refactor code

b2f76df

eshaibu requested a review from adamwardecki January 19, 2018 08:34

fix failing test

885ad45

eshaibu force-pushed the ft_collection_config branch from cdd205f to 885ad45 Compare January 22, 2018 06:03

refactor to use isAdmin feature

ceaeb86

eshaibu force-pushed the ft_collection_config branch from f5431f9 to ceaeb86 Compare February 2, 2018 03:19

eshaibu added 4 commits April 27, 2018 20:11

update socket endpoints

9dad782

update test cases

1a4013c

update socket to fully use async await

dc3bbfe

fix for handling of base64 bytes images

9f58775

eshaibu changed the title ~~Add collectionId to config~~ Update face auth socket Apr 29, 2018

eshaibu force-pushed the ft_collection_config branch 3 times, most recently from 35909b2 to 18b0e9f Compare April 29, 2018 01:26

fix failing test

00c21df

eshaibu force-pushed the ft_collection_config branch from 18b0e9f to 00c21df Compare April 29, 2018 01:30

update README.md

da98537

eshaibu force-pushed the ft_collection_config branch from 2cca206 to da98537 Compare April 30, 2018 05:34

adamwardecki suggested changes Apr 30, 2018

View reviewed changes

cleanup code

10d3a50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update face auth socket #2

Update face auth socket #2

eshaibu commented Jan 19, 2018 •

edited

Loading

adamwardecki Apr 30, 2018

adamwardecki Apr 30, 2018

adamwardecki Apr 30, 2018

adamwardecki Apr 30, 2018

adamwardecki Apr 30, 2018

eshaibu Apr 30, 2018

adamwardecki Apr 30, 2018

eshaibu Apr 30, 2018

adamwardecki Apr 30, 2018

adamwardecki Apr 30, 2018

adamwardecki Apr 30, 2018

adamwardecki Apr 30, 2018

Update face auth socket #2

Are you sure you want to change the base?

Update face auth socket #2

Conversation

eshaibu commented Jan 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eshaibu commented Jan 19, 2018 •

edited

Loading