[WIP] Update mupen64plus to latest upstream version #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is such a great idea
reading systembus currently crashing the emulator, might need to look into that
TODO: - allow enabling/disabling debugger dynamically, it really doesn't need to be on permanently, requires a mupen-side change tho - provide registers - figure out why size of mupen went +800kb, is it just -lopcodes, -lintl, -liberty? - debugger (trace and debugger itself) doesn't work in dynarec, notify or unregister services accordingly - figure out why cached interpreter has <60 fps
see TASEmulators#3220, probably fixes some controller and SDL exceptions i've been observing previously
|
Hm, I did a bit of testing with Donkey Kong 64 and it appears to be a GLideN64 plugin issue rather than a fault of anything in BizHawk, so it's unlikely I'll be able to resolve this. I also get broken video output in the old mupen core with gliden64 (in bizhawk), so it's not really a new regression. |
|
This is more or less ready from my side. I want to pull a couple more submodules once they're ready and of course this needs to be rebased, but aside from that the diff should be about final. Mainly needs more testing now, especially on linux and the parallel video plugin (vulkan). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress update of the mupen64plus core to the latest version. This would ideally improve compatibility and increase accuracy and be a real-time playable alternative to the existing ares64 core.
There's a couple of known TODOs that need to be resolved:
those are currently all default because no choices existdoneintegrate mupen core and plugin sources and build in the bizhawk repo; I currently build from a fork that is not checked in to bizhawk (https://github.com/Morilli/mupen64plus-core/tree/bizhawk)<-- done, added basic build script. There's still some issues while waiting for upstream commits, but assuming we fork all projects anyway that shouldn't be a blockerIDebuggablefunctionality is missing, mainly because registers aren't implemented. Registers not being implemented also affectsITraceableimpl (why is that required but only exposed inIDebuggable... whatever)The diff should be relatively clean, the commit history isn't. Best to look at the full diff instead of individual commits.