Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update author/source metadata for several cores where it's missing #4191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update author/source metadata for several cores where it's missing #4191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb9a90d
Update author/source metadata for several cores where it's missing
YoshiRulz Jan 16, 2025
bb1a493
Copy metadata to linked and subframe cores from base core
YoshiRulz Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Computers/MSX/MSX.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@

namespace BizHawk.Emulation.Cores.Computers.MSX
{
[Core(CoreNames.MSXHawk, "", isReleased: true)]
[Core(
name: CoreNames.MSXHawk,
author: "alyosha")]
public partial class MSX : IEmulator, IVideoProvider, ISoundProvider, ISaveRam, IInputPollable, IRegionable, ISettable<MSX.MSXSettings, MSX.MSXSyncSettings>
{
[CoreConstructor(VSystemID.Raw.MSX)]
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Atari/A7800Hawk/A7800Hawk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@

namespace BizHawk.Emulation.Cores.Atari.A7800Hawk
{
[Core(CoreNames.A7800Hawk, "")]
[Core(
name: CoreNames.A7800Hawk,
author: "alyosha and BizHawk contributors")]
[ServiceNotApplicable(typeof(ISettable<,>))]
public partial class A7800Hawk : IEmulator, ISaveRam, IDebuggable, IInputPollable,
IRegionable, IBoardInfo, ISettable<object, A7800Hawk.A7800SyncSettings>
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/GCE/Vectrex/VectrexHawk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

namespace BizHawk.Emulation.Cores.Consoles.Vectrex
{
[Core(CoreNames.VectrexHawk, "")]
[Core(
name: CoreNames.VectrexHawk,
author: "alyosha")]
public partial class VectrexHawk : IEmulator, ISaveRam, IDebuggable, IInputPollable, IRegionable,
ISettable<object, VectrexHawk.VectrexSyncSettings>
{
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Magnavox/Odyssey2/O2Hawk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

namespace BizHawk.Emulation.Cores.Consoles.O2Hawk
{
[Core(CoreNames.O2Hawk, "")]
[Core(
name: CoreNames.O2Hawk,
author: "alyosha")]
public partial class O2Hawk : IEmulator, ISaveRam, IDebuggable, IInputPollable, IRegionable, ISettable<O2Hawk.O2Settings, O2Hawk.O2SyncSettings>, IBoardInfo
{
// memory domains
Expand Down
7 changes: 6 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/3DS/Encore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@

namespace BizHawk.Emulation.Cores.Consoles.Nintendo.N3DS
{
[PortedCore(CoreNames.Encore, "", "nightly-2104", "https://github.com/CasualPokePlayer/encore", singleInstance: true)]
[PortedCore(
name: CoreNames.Encore,
author: "Tropic Haze and Citra contributors; port by CasualPokePlayer",
portedVersion: "nightly-2104",
portedUrl: "https://github.com/CasualPokePlayer/encore",
singleInstance: true)]
[ServiceNotApplicable(typeof(IRegionable))]
public partial class Encore : IRomInfo
{
Expand Down
6 changes: 5 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/BSNES/SubBsnesCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@

namespace BizHawk.Emulation.Cores.Nintendo.BSNES
{
[PortedCore(CoreNames.SubBsnes115, "")]
[PortedCore(
name: CoreNames.SubBsnes115,
author: "bsnes team",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port by Morilli?

portedVersion: "v115+",
portedUrl: "https://github.com/bsnes-emu/bsnes")]
public class SubBsnesCore : IEmulator, ICycleTiming
{
[CoreConstructor(VSystemID.Raw.Satellaview)]
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawk/GBHawk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@

namespace BizHawk.Emulation.Cores.Nintendo.GBHawk
{
[Core(CoreNames.GbHawk, "")]
[Core(
name: CoreNames.GbHawk,
author: "alyosha and BizHawk contributors")]
public partial class GBHawk : IEmulator, ISaveRam, IDebuggable, IInputPollable, IRegionable, IGameboyCommon,
ISettable<GBHawk.GBSettings, GBHawk.GBSyncSettings>
{
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawkLink/GBHawkLink.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

namespace BizHawk.Emulation.Cores.Nintendo.GBHawkLink
{
[Core(CoreNames.GBHawkLink, "")]
[Core(
name: CoreNames.GBHawkLink,
author: "alyosha and BizHawk contributors")]
public partial class GBHawkLink : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable, ILinkable,
ISettable<GBHawkLink.GBLinkSettings, GBHawkLink.GBLinkSyncSettings>,
ILinkedGameBoyCommon
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawkLink3x/GBHawkLink3x.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

namespace BizHawk.Emulation.Cores.Nintendo.GBHawkLink3x
{
[Core(CoreNames.GBHawkLink3x, "")]
[Core(
name: CoreNames.GBHawkLink3x,
author: "alyosha and BizHawk contributors")]
public partial class GBHawkLink3x : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable,
ISettable<GBHawkLink3x.GBLink3xSettings, GBHawkLink3x.GBLink3xSyncSettings>,
ILinkedGameBoyCommon
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawkLink4x/GBHawkLink4x.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

namespace BizHawk.Emulation.Cores.Nintendo.GBHawkLink4x
{
[Core(CoreNames.GBHawkLink4x, "")]
[Core(
name: CoreNames.GBHawkLink4x,
author: "alyosha and BizHawk contributors")]
public partial class GBHawkLink4x : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable,
ISettable<GBHawkLink4x.GBLink4xSettings, GBHawkLink4x.GBLink4xSyncSettings>,
ILinkedGameBoyCommon
Expand Down
7 changes: 6 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@

namespace BizHawk.Emulation.Cores.Nintendo.N64
{
[PortedCore(CoreNames.Mupen64Plus, "", "2.0", "https://code.google.com/p/mupen64plus/", singleInstance: true)]
[PortedCore(
name: CoreNames.Mupen64Plus,
author: "(for core:) Mupen64 contributors and Mupen64Plus contributors; port by micro500 and BizHawk contributors",
Copy link
Contributor

@vadosnaprimer vadosnaprimer Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
author: "(for core:) Mupen64 contributors and Mupen64Plus contributors; port by micro500 and BizHawk contributors",
author: "Mupen64 contributors and Mupen64Plus contributors; port by micro500 and BizHawk contributors",

portedVersion: "2.0",
portedUrl: "https://github.com/mupen64plus/mupen64plus-core",
singleInstance: true)]
public partial class N64 : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IDisassemblable, IRegionable,
ISettable<N64Settings, N64SyncSettings>
{
Expand Down
6 changes: 5 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/SNES9X/Snes9x.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@

namespace BizHawk.Emulation.Cores.Nintendo.SNES9X
{
[PortedCore(CoreNames.Snes9X, "", "e49165c", "https://github.com/snes9xgit/snes9x")]
[PortedCore(
name: CoreNames.Snes9X,
author: "Snes9x contributors; port by Morilli",
portedVersion: "e49165c",
portedUrl: "https://github.com/snes9xgit/snes9x")]
public class Snes9x : WaterboxCore,
ISettable<Snes9x.Settings, Snes9x.SyncSettings>, IRegionable
{
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/SubGBHawk/SubGBHawk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

namespace BizHawk.Emulation.Cores.Nintendo.SubGBHawk
{
[Core(CoreNames.SubGbHawk, "")]
[Core(
name: CoreNames.SubGbHawk,
author: "alyosha and BizHawk contributors")]
public partial class SubGBHawk : IEmulator, IStatable, IInputPollable,
ISettable<GBHawk.GBHawk.GBSettings, GBHawk.GBHawk.GBSyncSettings>, IDebuggable, ICycleTiming, IGameboyCommon
{
Expand Down
4 changes: 3 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Nintendo/SubNESHawk/SubNESHawk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

namespace BizHawk.Emulation.Cores.Nintendo.SubNESHawk
{
[Core(CoreNames.SubNesHawk, "")]
[Core(
name: CoreNames.SubNesHawk,
author: "zeromus, natt, alyosha, adelikat")]
public partial class SubNESHawk : IEmulator, IStatable, IInputPollable, ISettable<NES.NES.NESSettings, NES.NES.NESSyncSettings>
{
[CoreConstructor(VSystemID.Raw.NES, Priority = CorePriority.SuperLow)]
Expand Down
5 changes: 4 additions & 1 deletion src/BizHawk.Emulation.Cores/Consoles/Sega/GGHawkLink/GGHawkLink.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@

namespace BizHawk.Emulation.Cores.Sega.GGHawkLink
{
[Core(CoreNames.GGHawkLink, "", isReleased: false)]
[Core(
name: CoreNames.GGHawkLink,
author: "Vecna",
isReleased: false)]
public partial class GGHawkLink : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable, ILinkable,
ISettable<GGHawkLink.GGLinkSettings, GGHawkLink.GGLinkSyncSettings>
{
Expand Down
Loading