Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): Re-write regexes to fix re-dos threat https://github.c… #5498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coheigea
Copy link
Member

@coheigea coheigea commented Feb 6, 2025

…om/Talend/ui/security/code-scanning/2700

What is the problem this PR is trying to solve?

Fix https://github.com/Talend/ui/security/code-scanning/2700 by restricting character set and amount of characters in the regexes to parse times

What is the chosen solution to this problem?

Copilot was used to change the regexes. I manually tested them in js console.

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Storybook for this PR deployed on this github page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant