Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fall through between cases in light_mem_seek() #33

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Don't fall through between cases in light_mem_seek() #33

merged 1 commit into from
Mar 29, 2024

Conversation

IsaacsLab42
Copy link
Contributor

The switch statement in the function light_mem_seek() falls through all of the cases, resulting in an invalid offset, as described in issue #32.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.25%. Comparing base (f595e4b) to head (1609023).
Report is 1 commits behind head on master.

Files Patch % Lines
src/light_io_mem.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   74.49%   74.25%   -0.24%     
==========================================
  Files          17       17              
  Lines        1145     1146       +1     
  Branches        0      151     +151     
==========================================
- Hits          853      851       -2     
- Misses        292      295       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kayoub5 kayoub5 merged commit 093fdf5 into Technica-Engineering:master Mar 29, 2024
7 of 10 checks passed
@IsaacsLab42 IsaacsLab42 deleted the case_fallthrough branch March 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants