This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
component のディレクトリ構成を変更する #5404
Merged
soutaito
merged 73 commits into
Tokyo-Metro-Gov:development
from
nard-tech:feature/#2790-change-directory-of-components
May 26, 2021
Merged
component のディレクトリ構成を変更する #5404
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
53ae289
検査陽性者の状況: Rename components/cards/ConfirmedCasesDetailsCard.vue to co…
nard-tech 97a9ead
検査陽性者の状況: Rename components/ConfirmedCasesDetailsTable.vue to compone…
nard-tech 7d3ec40
報告日別による陽性者数の推移: Rename components/cards/ConfirmedCasesNumberCard.vue …
nard-tech f6c14aa
モニタリング項目: Rename components/cards/MonitoringItemsOverviewCard.vue to …
nard-tech fba9a1f
モニタリング項目: Rename components/MonitoringItemsOverviewTableInfectionStat…
nard-tech 5422ecf
モニタリング項目: Rename components/MonitoringItemsOverviewTableMedicalSystem…
nard-tech c8173b9
モニタリング項目: Rename components/MonitoringItemsOverviewTableValueWithTran…
nard-tech c57aad3
新規陽性者数: Rename components/cards/MonitoringConfirmedCasesNumberCard.vu…
nard-tech 58b6618
新規陽性者数: Rename components/MonitoringConfirmedCasesChart.vue to compon…
nard-tech 160127e
7119における発熱等相談件数: Rename components/cards/ConsultationAboutFeverNumber…
nard-tech bd1796e
新規陽性者における接触歴等不明者数: Rename components/cards/UntrackedRateCard.vue to c…
nard-tech 0a32776
新規陽性者における接触歴等不明者数: Rename components/UntrackedRateMixedChart to compo…
nard-tech 8e041e9
検査の陽性率: Rename components/cards/PositiveRateCard.vue to components/in…
nard-tech abf645f
検査の陽性率: Rename components/PositiveRateMixedChart.vue to components/in…
nard-tech 7ce1ee6
救急医療の東京ルールの適用件数; Rename components/cards/TokyoRulesApplicationNumberC…
nard-tech 9188f6c
入院患者数: Rename components/cards/HospitalizedNumberCard.vue to componen…
nard-tech d7a897e
入院患者数: Rename components/DashedRectangleTimeBarChart.vue to component…
nard-tech a0d18dd
重症患者数: Rename components/cards/SevereCaseCard.vue to components/index…
nard-tech e846981
重症患者数: Rename components/SevereCaseBarChart.vue to components/index/C…
nard-tech d2cc7bb
陽性者の属性: Rename components/cards/ConfirmedCasesAttributesCard.vue to c…
nard-tech 79975a4
陽性者の属性: Rename components/DataTable.vue to components/index/CardsRefe…
nard-tech b6c41d6
陽性者の属性: Rename utils/formatTable.ts to utils/formatConfirmedCasesAttr…
nard-tech 394d301
陽性者数(区市町村別): Rename components/cards/ConfirmedCasesByMunicipalitiesCa…
nard-tech 5317889
陽性者数(区市町村別): Rename components/ConfirmedCasesByMunicipalitiesTable.vu…
nard-tech 812b3b6
発症日別による陽性者数の推移: Rename components/cards/PositiveNumberByDevelopedDate…
nard-tech 4f28032
発症日別による陽性者数の推移: Rename components/DataViewCustomInfoPanel.vue to comp…
nard-tech 030888f
確定日別による陽性者数の推移: Rename components/cards/PositiveNumberByDiagnosedDate…
nard-tech 0289272
死亡日別による死亡者数の推移: Rename components/cards/DeathsByDeathDateCard.vue to …
nard-tech 7f80f95
検査実施件数: Rename components/cards/TestedNumberCard.vue to components/in…
nard-tech 42de3a4
検査実施件数: Rename components/TimeStackedBarChart.vue to components/index…
nard-tech 09444cf
N501Y変異株スクリーニングの実施状況: Rename components/cards/VariantCard.vue to comp…
nard-tech 490789e
N501Y変異株スクリーニングの実施状況: Rename components/VariantChart.vue to component…
nard-tech bca2d53
新型コロナコールセンター相談件数: Rename components/cards/TelephoneAdvisoryReportsNum…
nard-tech 6e62387
受診相談窓口における相談件数: components/cards/MonitoringConsultationDeskReportsNum…
nard-tech da9f29e
受診相談窓口における相談件数: Rename components/MonitoringConsultationDeskReportCha…
nard-tech 40bf634
東京都発熱相談センターにおける相談件数: Rename components/cards/TokyoFeverConsultationCe…
nard-tech 5d3d4ff
東京都発熱相談センターにおける相談件数: Rename components/FeverMixedChart.vue to compone…
nard-tech 74c8f4f
都営地下鉄の利用者数の推移: Rename components/cards/MetroCard.vue to components/in…
nard-tech 8dbb92b
都営地下鉄の利用者数の推移: Rename components/MetroBarChart.vue.vue to components/…
nard-tech ec7f421
都庁来庁者数の推移: Rename components/cards/AgencyCard.vue to components/index…
nard-tech 9cf5b74
都庁来庁者数の推移: Rename components/AgencyBarChart.vue to components/index/C…
nard-tech f1a0693
モニタリング項目: Rename components/CardsMonitoring.vue to components/index/C…
nard-tech c3d3258
その他 参考指標: Rename components/CardsReference.vue to components/index/Ca…
nard-tech fa1788c
Rename components/SideNavigation.vue to components/_shared/SideNaviga…
nard-tech 54b42e3
Rename components/LanguageSelector.vue to components/_shared/SideNavi…
nard-tech da0a88c
Rename components/MenuList.vue to components/_shared/SideNavigation/M…
nard-tech ba76912
Rename components/DevelopmentModeMark.vue to components/_shared/Devel…
nard-tech 1619c91
Rename components/NoScript.vue to components/_shared/NoScript.vue
nard-tech ce6d5ed
Rename components/SiteTopUpper.vue to components/index/SiteTopUpper.vue
nard-tech d8c4553
Rename components/WhatsNew.vue to components/index/SiteTopUpper/Whats…
nard-tech cf3cfab
感染状況・医療提供体制(サマリ): Rename components/InfectionMedicalcareprovisionStat…
nard-tech 01cfc78
感染状況・医療提供体制の分析: Rename components/MonitoringCommentCard.vue to compon…
nard-tech 9fb7b5e
感染状況・医療提供体制の分析: Rename components/MonitoringCommentCardImageSwipe.vue…
nard-tech 3fc3e99
感染状況・医療提供体制の分析: Rename components/MonitoringCommentFrame.vue to compo…
nard-tech d9b1107
都内の滞在人口の増減状況: Rename components/StayingPopulation.vue to components/i…
nard-tech 53f77e4
自分や家族の症状に不安や心配があればまずは電話相談をどうぞ: Rename components/Consultation.vue to …
nard-tech 84aa10a
Rename components/AppLink.vue to components/_shared/AppLink.vue
nard-tech 7fbe321
Rename components/CardsTab.vue to components/index/CardsTab.vue
nard-tech 8322ba3
Rename components/CardsLazyRow.vue to components/index/_shared/CardsL…
nard-tech a8e428e
Rename components/cards/CardRow.vue to components/index/_shared/CardR…
nard-tech 259db2c
7119における発熱等相談件数,救急医療の東京ルールの適用件数: Rename components/MixedBarAndLineCha…
nard-tech ad0d94d
Rename components/TimeBarChart.vue to components/index/_shared/TimeBa…
nard-tech 23b56a2
オープンデータを入手: Rename components/OpenDataLink.vue to components/index/_s…
nard-tech ab262e5
Rename components/PageHeader.vue to components/_shared/PageHeader.vue
nard-tech db2bfb1
Rename components/DataSelector.vue to components/index/_shared/DataSe…
nard-tech 4cc0f6a
Rename components/ScrollableChart.vue to components/index/_shared/Scr…
nard-tech c987834
Rename components/StaticCard.vue to components/_shared/StaticCard.vue
nard-tech 62cf468
Rename components/StaticInfo.vue to components/index/SiteTopUpper/Con…
nard-tech d47b878
Rename components/DataView.vue to components/index/_shared/DataView.vue
nard-tech 75894c3
テーブルを表示: Rename components/DataViewExpantionPanel.vue to components/i…
nard-tech d03c3dc
情報をシェアする: Rename components/DataViewShare.vue to components/index/_sh…
nard-tech ff0d280
Rename components/DataViewDataSetPanel.vue to components/index/_share…
nard-tech fdd9668
Rename components/DataViewTable.vue to components/index/_shared/DataV…
nard-tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM後にすみません、一部カードのimport時のネーミングルールがミスっている気がします....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
フォローありがとうございます!ここは削除行のようですが、どうなんでしょう?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すみません、範囲選択ミスなんですが、
Chart
としてimport、使用されていますThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
私の理解では
Card
でChart
を配置する、というルールかと思っているのですが、どうなんでしょう? @nard-techThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
他では
と言った形でimportされている箇所があるようです。
Chart
と言った形でimportされているところと、このようにフルネームでimportされているところで、ネーミングルールのばらつきがあるのはどうなんだろう?といった指摘でした。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このコメントでは、区別する必要がなければ
Chart
としてimportすれば良いというように結論づいているように見えましたが、どうなんでしょうか...(つまり、このコメントに従うなら私が指摘すべき所をミスってるわけ(Chart
としてimportしていない所を指摘すべき)ですが...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうですね!おそらく後者が修正もれですね。
また後日の修正でも大丈夫なので、いったんここでマージしますね!
@y-chan フォロー感謝です!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@y-chan @kaizumaki キャッチアップできずすみません.merge ありがとうございます.後ほど確認して必要なら修正します.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nard-tech ぜんぜん後日で大丈夫です!よろしくお願いします 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@y-chan @kaizumaki #6368 を作成しました.ご確認ください.