-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Implement Dark Mode #95
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tresleches ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @Readpato thanks for taking the time to bring everything from the fork to the repo and for the granular and detailed git commit history, 👏🏻 Small thing, (I missed it when asking the first time) when creating the branch add the number of the issue like I'm gonna check the PR today, let you know soon |
@Readpato I just committed a small change regarding the styles of the icon for toggling the dark mode. Before it had the same visual hierarchy as the cake icon (which symbolizes the mini branding of the component and will serve as an expand/collapse button in the near future) so since the functionality is also different I changed for a more subtle icon (also the right part is gonna serve as a toolbar of actions, where we will add a search icon soon) Let me know what do you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazin job @Readpato, looks amazing
@@ -20,18 +20,18 @@ const toggle = () => { | |||
</script> | |||
|
|||
<template> | |||
<div class="tl-mb-4"> | |||
<div class="tl-mb-4 tl-w-full tl-border-x-none tl-border-solid tl-border-1 tl-border-primary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I tried to emulate the tweak pane folder component, which it clearly denoted the separation between one folder and another. I don't mind turning it back or adapting the old styles (which I removed without asking, my bad) to the new component =] Let me know!
Hey @alvarosabu! Thank you for your review. Means a lot <3 |
Description
Summary
Changes
What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)
Does this PR introduce a breaking change? (check one)
Screenshots and videos
leches-dark-mode.mov
The PR fulfils these requirements:
If adding a new feature, the PR's description includes:
Dark mode is a good implementation to improve the UX for everyone that utilizes the package.
Other information:
Let me know any changes that need to be done if needed!