Address @Miepee suggestions.

UnderminersTeam · Dec 30, 2023 · b7f6a89 · b7f6a89
1 parent e3c8837
commit b7f6a89
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/UndertaleModLib/Decompiler/Decompiler.cs b/UndertaleModLib/Decompiler/Decompiler.cs
@@ -3986,6 +3986,8 @@ public static void BuildSubFunctionCache(UndertaleData data)
                 data.KnownSubFunctions = new Dictionary<string, UndertaleFunction>();
                 GlobalDecompileContext globalDecompileContext = new GlobalDecompileContext(data, false);
 
+                // TODO: Is this necessary?
+                // Doesn't the latter `Parallel.ForEach()` already cover this?
                 foreach (var func in data.Functions)
                 {
                     if (func.Name.Content.StartsWith("gml_Script_"))

diff --git a/UndertaleModTool/Editors/UndertaleCodeEditor.xaml.cs b/UndertaleModTool/Editors/UndertaleCodeEditor.xaml.cs
@@ -714,16 +714,13 @@ private async Task DecompileCode(UndertaleCode code, bool first, LoaderDialog ex
                                     for (int i = 0; i < matches.Length; i++)
                                     {
                                         Match match = matches[i];
-                                        if (match.Success)
-                                        {
-                                            if (currDict.TryGetValue(match.Groups[1].Value, out string text))
-                                            {
-                                                if (i != matches.Length - 1) // if not the last
-                                                    decompLinesBuilder.Append($"{text}; ");
-                                                else
-                                                    decompLinesBuilder.Append(text + '\n');
-                                            }
-                                        }
+                                        if (!currDict.TryGetValue(match.Groups[1].Value, out string text))
+                                            continue;
+
+                                        if (i != matches.Length - 1) // If not the last
+                                            decompLinesBuilder.Append($"{text}; ");
+                                        else
+                                            decompLinesBuilder.Append(text + '\n');
                                     }
                                 }
                                 else