Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yda 6174 fix group import group with commas #390

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

leonidastri
Copy link
Contributor

This is a fix for when a user tries to upload a csv with group definitions and the groupname contained comma(s) then buttons acted strangely containing the data error and the data error and danger symbol in the row were not shown.

Fix:
Now, when a user tries to upload a csv with group definitions and the groupname contains comma(s) then the danger symbol is shown with the error message and no buttons are altered.

@lwesterhof lwesterhof self-requested a review February 6, 2025 07:26
Copy link
Member

@lwesterhof lwesterhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lwesterhof lwesterhof merged commit 0cbb639 into development Feb 6, 2025
10 checks passed
@lwesterhof lwesterhof deleted the YDA-6174-fix-group-import-group-with-commas branch February 6, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants