-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify tests and add Sendable to subtypes #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvdLee
requested review from
kairadiagne,
BasThomas and
raphkoebraam
as code owners
January 2, 2024 13:18
SwiftLint found issues
Generated by 🚫 Danger Swift against d4014d0 |
BasThomas
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
kairadiagne
approved these changes
Jan 5, 2024
Congratulations! 🎉 This was released as part of Release 3.0.2 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to make Mocker conform to
Sendable
, I realized it's not making much sense for the nature of this project. Any mutations toMock
are done before the mock is registered and right now, it does not make any sense to change properties after registration.If we would make
Mock
conform toSendable
, we would have to make all its properties including closuresSendable
too. This would cause a huge impact on codebases since our tests are usingonRequest
handlers and others while capturing many non-sendable types. Therefore, I don't think it makes sense for this project, for testing purposes designed, to conform to Sendable in the short term.Yet, I did add a few conformances that don't hurt 👌