Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Add rule to prevent usage of the word 'sidebar' in translatable strings #68894

Merged
merged 9 commits into from
Feb 12, 2025
Merged

ESLint: Add rule to prevent usage of the word 'sidebar' in translatable strings #68894

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0fa9376
add: Sidebar lint warning in eslintrc
im3dabasia Jan 27, 2025
ffd1d08
fix: Add eslint rule to ensure word is flagged at all positions
im3dabasia Jan 27, 2025
5a444e4
fix: Update regex for better control
im3dabasia Jan 30, 2025
be0f32a
fix: Update rule message to include alternate word suggestion
im3dabasia Feb 7, 2025
cce5eec
fix: Updated strings to use panel
im3dabasia Feb 10, 2025
975f3ff
fix: Update sidebar lint regex
im3dabasia Feb 10, 2025
030309d
fix: Update string to use side bar in sidebar
im3dabasia Feb 10, 2025
e00e7b0
revert: Panel changes in non editor packages
im3dabasia Feb 11, 2025
85b5f8e
fix: Revert changes for post-template sidebar word
im3dabasia Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,12 @@ const restrictedSyntax = [
'CallExpression[callee.name=/^(__|_x|_n|_nx)$/] > Literal[value=/^toggle\\b/i]',
message: "Avoid using the verb 'Toggle' in translatable strings",
},
{
selector:
'CallExpression[callee.name=/^(__|_x|_n|_nx)$/] > Literal[value=/sidebar\\b/i]',
message:
"Avoid using the word 'sidebar' in translatable strings. Consider using 'panel' instead.",
},
];

/** `no-restricted-syntax` rules for components. */
Expand Down
Loading