E2E Tests: Add Block Hooks Test Coverage #69044
Open
+366
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Package] E2E Tests
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
ockham
force-pushed
the
add/block-hooks-e2e-tests
branch
4 times, most recently
from
04aec39 to
0ab1eda
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
reviewed
Feb 14, 2025
| title: 'Navigation Menu', | ||
| status: 'publish', | ||
| content: | ||
| '<!-- wp:navigation-link {"label":"wordpress.org","url":"https://wordpress.org","kind":"custom"} /-->', // '<!-- wp:page-list /-->', |
There was a problem hiding this comment.
Why is there a code comment with a different block included?
There was a problem hiding this comment.
These two failing tests might be related to that:
There was a problem hiding this comment.
Oh, I think that's an oversight on my part. I'll remove it.
gziolo
force-pushed
the
add/block-hooks-e2e-tests
branch
from
962d917 to
495e14a
Compare
|
I landed #68926 and rebased the branch to ensure all tests pass on CI. |
gziolo
reviewed
Feb 14, 2025
| page.locator( '.wp-block-navigation__container > *' ) | ||
| ).toHaveClass( [ | ||
| 'wp-block-navigation-item wp-block-home-link', | ||
| ' wp-block-navigation-item wp-block-navigation-link', |
There was a problem hiding this comment.
Is this preceding space intentional?
There was a problem hiding this comment.
Yeah, the selector doesn't work without it 😕 I guess it's a (minor) bug in the block code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add end-to-end test coverage for Block Hooks; specifically for insertion into post content, synced patterns, and Navigation blocks. The tests check that hooked blocks are inserted correctly on the frontend, and that any changes made in the editor are persisted and respected.
They cover both "normal" insertion (i.e. before or after a given anchor block), and first/last child insertion with the containing block serving as the anchor block (which is when the corresponding post object's post meta is used to store
_wp_ignored_hooked_blocksdata).Note that some tests are currently failing. This is due to a bug uncovered while creating the tests. There's a fix in #69142. You can verify that it fixes the failing tests by locally cherry-picking 9750de5 on top of this PR.
Closes #68986.
Why?
While working on #68926, it became clear that manually testing all cases is becoming more and more unwieldy. It was thus suggested that we add e2e test coverage.
Testing Instructions
Check the relevant GHA workflows.
You can also run e2e tests locally:
Add
--headedto see them run in a local Chromium instance.As mentioned above, they will currently fail. You can however cherry-pick 9750de5 (from #69142) and re-run tests to verify that it allows them to pass.
TODO
after)