Fix: Add the border width on initial color change for border

[hbhalodia]

What?

Fixes: #69094

• PR adds the condition of undefined on initial render to set the width to 1px for border, if user adds/changes the color before explicitly setting the width.

Why?

• Closes - Gutenberg border block setting should be working properly. #69094
• It solves the issue related to border width not set when adding the color at first before explicitly setting the width.

How?

• PR adds the undefined condition with the 0 width check.

Testing Instructions

1. Open any page/post.
2. Add any paragraph.
3. Go to inspector control and enable border.
4. Set the border color first, you would notice it would also add 1px width for border.

Testing Instructions for Keyboard

• None

Screenshots or screencast

BorderFix.mov

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
• Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: coder-rancho <[email protected]>
Co-authored-by: viralsampat-multidots <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[coder-rancho]

Use YODA condition:

Suggested change

	const hasZeroWidth = widthValue === 0 || undefined === widthValue;
	const hasZeroWidth = 0 === widthValue || undefined === widthValue;

[hbhalodia]

Hi @coder-rancho, Thanks for pointing this out, but new coding standards proposes not to use Yoda Conditions. The codebase have bunch of files that are not using Yoda conditions. I would update the PR if core team want's to use Yoda condition here.

Thank You,