Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Fix image resizing issues with manual width input #69115

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dhruvikpatel18
Copy link
Contributor

Fixes: #68814

What?

Fix manual image size input being disregarded after clicking an image by removing minimum size constraints from the resizable container.

Why?

Currently, when users manually set the width of an image, the size is unexpectedly reset to a minimum size after clicking the image in the editor. This happens because the resizable container has default minimum dimensions that override the manually input values. This creates a frustrating user experience when trying to resize images to small dimensions.

Testing Instructions

  1. Add a row or stack block to a page or post
  2. Insert an image block within the row or stack.
  3. Select the image block.
  4. Try to set the width to a small value (e.g., 80px) using the Width input field
  5. Verify that the image maintains its manually set width instead of resetting to a larger size
  6. Try different width values to ensure the behavior is consistent
  7. Test with different image sizes and alignments to ensure the fix doesn't affect other image block functionality

Screenshots or screencast

Before:

Screen.Recording.2025-02-10.at.4.03.08.PM.mov

After:

Screen.Recording.2025-02-10.at.4.17.49.PM.mov

@dhruvikpatel18 dhruvikpatel18 changed the title Fix: Ensure manual image size input persists in the editor Image Block: Fix image resizing issues with manual width input Feb 10, 2025
@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review February 10, 2025 11:19
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @davewhitley.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: davewhitley.

Co-authored-by: dhruvikpatel18 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual image size input disregarded after clicking an image
1 participant