Post Template Panel: Display popover on the left side of the sidebar #69134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
t-hamano
commented
Feb 11, 2025
| <ClassicThemeControl /> | ||
| </PostPanelRow> | ||
| ); | ||
| return <ClassicThemeControl />; |
There was a problem hiding this comment.
Perhaps by using a common PostPanelRow for both the classic theme and the block theme, popoverProps can be made common.
However, the conditions here are a bit complicated, so for now I've used the PostPanelRow component for both the classic theme control and the block theme control. Also, the conditions here may change as a result of the discussion in #64341.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed that in the post sidebar, only the post template popovers are positioned differently:
Why?
For consistency in popover positioning
How?
Like many other Panel implementations, uses a
PanelRowas an anchor (Example).Testing Instructions
Check the position of the popover in both the block and classic themes.
Screenshots or screencast
a1e30df09fe9229a322f8c86f771d162.mp4