Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Data: add type for term entity #69151

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Core Data: add type for term entity #69151

merged 1 commit into from
Feb 11, 2025

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Feb 11, 2025

What?

Follow-up to #67668, makes it easy to use proper types when doing something like wp.data.select('core').getEntityRecords('taxonomy', 'category')

Why?

See above

How?

By adding types

Testing Instructions

n/a

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

Follow-up to #67668, makes it easy to use term types with `getEntityRecords` and the like
@swissspidy swissspidy added [Package] Core data /packages/core-data [Type] Code Quality Issues or PRs that relate to code quality labels Feb 11, 2025
@swissspidy swissspidy marked this pull request as ready for review February 11, 2025 17:33
@swissspidy swissspidy requested a review from nerrad as a code owner February 11, 2025 17:33
@swissspidy swissspidy requested a review from tyxla February 11, 2025 17:34
Copy link

github-actions bot commented Feb 11, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: swissspidy <[email protected]>
Co-authored-by: manzoorwanijk <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@swissspidy swissspidy merged commit fe2195e into trunk Feb 11, 2025
71 of 72 checks passed
@swissspidy swissspidy deleted the add-term-type branch February 11, 2025 19:21
@github-actions github-actions bot added this to the Gutenberg 20.3 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Core data /packages/core-data [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants