Site Hub: Navigate correctly in mobile view #69157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: -15 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fb3e8e1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13280187917
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
stokesman
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
This worked perfectly in my tests. In the mobile breakpoints:
- With a block theme it links to the dashboard from the root level and in other levels it links to the root.
- With a classic theme it links to the root from Styles/Patterns and from the root the dashboard is linked.
As expected the navigation for non-mobile breakpoints is unaffected.
The code changes are very straightforward and LGTM.
|
@stokesman Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69155
This PR fixes the site hub so that it points to the correct navigation destination in mobile view.
Why?
As mentioned in #69155, the following two problems have occurred:
How?
Regardless of theme type, check if the current path is a root.
Testing Instructions
In the mobile view, test the following navigation:
Block Theme
Classic Theme