Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format-library: Text-color ColorPalette IsRenderedInSidebar #69169

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+2 −0
Open

Format-library: Text-color ColorPalette IsRenderedInSidebar #69169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e908812
Format-library: Text-color ColorPalette IsRenderedInSidebar
shimotmk Feb 12, 2025
79d1de1
Update comment
shimotmk Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/format-library/src/text-color/inline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ function ColorPicker( { name, property, value, onChange } ) {
setColors( value, name, colors, { [ property ]: color } )
);
} }
// Prevent the text and color picker from overlapping.
__experimentalIsRenderedInSidebar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prop could use better naming, not specific to the location where the component is rendered.

Do you mind adding a small inline comment explaining what it does in this particular case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review!
Of course. Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mamaduka
I added the following comment out, what do you think?

Prevent the text and color picker from overlapping.

/>
);
}
Expand Down
Loading