-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Utils: Restrict file uploads with multiple
prop in uploadMedia
and mediaUpload
#69175
Merged
Mamaduka
merged 5 commits into
WordPress:trunk
from
yogeshbhutkar:enhance-68629/limit-file-uploads
Feb 15, 2025
+33
−11
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e3181a0
feat: restrict file uploads with `multiple` prop
yogeshbhutkar 76d06c1
fix: set default value for `multiple` prop
yogeshbhutkar d6f3827
fix: update error message to reflect single file upload restriction
yogeshbhutkar d1c61d1
fix: revert type changes to `UploadError`
yogeshbhutkar 9b55f51
test: add validation for single file upload mode
yogeshbhutkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,6 +42,8 @@ interface UploadMediaArgs { | |
wpAllowedMimeTypes?: Record< string, string > | null; | ||
// Abort signal. | ||
signal?: AbortSignal; | ||
// Whether to allow multiple files to be uploaded. | ||
multiple?: boolean; | ||
} | ||
|
||
/** | ||
|
@@ -57,6 +59,7 @@ interface UploadMediaArgs { | |
* @param $0.onFileChange Function called each time a file or a temporary representation of the file is available. | ||
* @param $0.wpAllowedMimeTypes List of allowed mime types and file extensions. | ||
* @param $0.signal Abort signal. | ||
* @param $0.multiple Whether to allow multiple files to be uploaded. | ||
*/ | ||
export function uploadMedia( { | ||
wpAllowedMimeTypes, | ||
|
@@ -67,7 +70,13 @@ export function uploadMedia( { | |
onError, | ||
onFileChange, | ||
signal, | ||
multiple = true, | ||
}: UploadMediaArgs ) { | ||
if ( ! multiple && filesList.length > 1 ) { | ||
onError?.( new Error( __( 'Only one file can be used here.' ) ) ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the error message could be improved, but I don't have better ideas at the moment. Let's follow-up on it as needed. |
||
return; | ||
} | ||
|
||
const validFiles = []; | ||
|
||
const filesSet: Array< Partial< Attachment > | null > = []; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a unit test for this accordingly in
packages/media-utils/src/utils/test/upload-media.ts