Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fix background image for use featured image for Cover block #69198

Closed
wants to merge 2 commits into from
Closed

Enable fix background image for use featured image for Cover block #69198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a20f21
Enable fix background image for use featured image
rinkalpagdar Feb 14, 2025
f4751b3
Linting Fixed
rinkalpagdar Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 103 additions & 109 deletions packages/block-library/src/cover/edit/inspector-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,135 +189,129 @@ export default function CoverInspectorControls( {
return (
<>
<InspectorControls>
{ !! url && (
<ToolsPanel
label={ __( 'Settings' ) }
resetAll={ () => {
setAttributes( {
hasParallax: false,
focalPoint: undefined,
isRepeated: false,
alt: '',
sizeSlug: undefined,
} );
} }
dropdownMenuProps={ dropdownMenuProps }
>
{ isImageBackground && (
<>
<ToolsPanelItem
label={ __( 'Fixed background' ) }
isShownByDefault
hasValue={ () => hasParallax }
onDeselect={ () =>
setAttributes( {
hasParallax: false,
focalPoint: undefined,
} )
}
>
<ToggleControl
__nextHasNoMarginBottom
label={ __( 'Fixed background' ) }
checked={ hasParallax }
onChange={ toggleParallax }
/>
</ToolsPanelItem>

<ToolsPanelItem
label={ __( 'Repeated background' ) }
isShownByDefault
hasValue={ () => isRepeated }
onDeselect={ () =>
setAttributes( {
isRepeated: false,
} )
}
>
<ToggleControl
__nextHasNoMarginBottom
label={ __( 'Repeated background' ) }
checked={ isRepeated }
onChange={ toggleIsRepeated }
/>
</ToolsPanelItem>
</>
) }
{ showFocalPointPicker && (
<ToolsPanel
label={ __( 'Settings' ) }
resetAll={ () => {
setAttributes( {
hasParallax: false,
focalPoint: undefined,
isRepeated: false,
alt: '',
sizeSlug: undefined,
} );
} }
dropdownMenuProps={ dropdownMenuProps }
>
{ isImageBackground && (
<>
<ToolsPanelItem
label={ __( 'Focal point' ) }
label={ __( 'Fixed background' ) }
isShownByDefault
hasValue={ () => !! focalPoint }
hasValue={ () => hasParallax }
onDeselect={ () =>
setAttributes( {
hasParallax: false,
focalPoint: undefined,
} )
}
>
<FocalPointPicker
<ToggleControl
__nextHasNoMarginBottom
label={ __( 'Focal point' ) }
url={ url }
value={ focalPoint }
onDragStart={ imperativeFocalPointPreview }
onDrag={ imperativeFocalPointPreview }
onChange={ ( newFocalPoint ) =>
setAttributes( {
focalPoint: newFocalPoint,
} )
}
label={ __( 'Fixed background' ) }
checked={ hasParallax }
onChange={ toggleParallax }
/>
</ToolsPanelItem>
) }
{ ! useFeaturedImage && url && ! isVideoBackground && (

<ToolsPanelItem
label={ __( 'Alternative text' ) }
label={ __( 'Repeated background' ) }
isShownByDefault
hasValue={ () => !! alt }
hasValue={ () => isRepeated }
onDeselect={ () =>
setAttributes( { alt: '' } )
setAttributes( {
isRepeated: false,
} )
}
>
<TextareaControl
<ToggleControl
__nextHasNoMarginBottom
label={ __( 'Alternative text' ) }
value={ alt }
onChange={ ( newAlt ) =>
setAttributes( { alt: newAlt } )
}
help={
<>
<ExternalLink
href={
// translators: Localized tutorial, if one exists. W3C Web Accessibility Initiative link has list of existing translations.
__(
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
)
}
>
{ __(
'Describe the purpose of the image.'
) }
</ExternalLink>
<br />
{ __(
'Leave empty if decorative.'
) }
</>
}
label={ __( 'Repeated background' ) }
checked={ isRepeated }
onChange={ toggleIsRepeated }
/>
</ToolsPanelItem>
) }
{ !! imageSizeOptions?.length && (
<ResolutionTool
value={ sizeSlug }
onChange={ updateImage }
options={ imageSizeOptions }
defaultValue={ DEFAULT_MEDIA_SIZE_SLUG }
</>
) }
{ showFocalPointPicker && (
<ToolsPanelItem
label={ __( 'Focal point' ) }
isShownByDefault
hasValue={ () => !! focalPoint }
onDeselect={ () =>
setAttributes( {
focalPoint: undefined,
} )
}
>
<FocalPointPicker
__nextHasNoMarginBottom
label={ __( 'Focal point' ) }
url={ url }
value={ focalPoint }
onDragStart={ imperativeFocalPointPreview }
onDrag={ imperativeFocalPointPreview }
onChange={ ( newFocalPoint ) =>
setAttributes( {
focalPoint: newFocalPoint,
} )
}
/>
) }
</ToolsPanel>
) }
</ToolsPanelItem>
) }
{ ! useFeaturedImage && url && ! isVideoBackground && (
<ToolsPanelItem
label={ __( 'Alternative text' ) }
isShownByDefault
hasValue={ () => !! alt }
onDeselect={ () => setAttributes( { alt: '' } ) }
>
<TextareaControl
__nextHasNoMarginBottom
label={ __( 'Alternative text' ) }
value={ alt }
onChange={ ( newAlt ) =>
setAttributes( { alt: newAlt } )
}
help={
<>
<ExternalLink
href={
// translators: Localized tutorial, if one exists. W3C Web Accessibility Initiative link has list of existing translations.
__(
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
)
}
>
{ __(
'Describe the purpose of the image.'
) }
</ExternalLink>
<br />
{ __( 'Leave empty if decorative.' ) }
</>
}
/>
</ToolsPanelItem>
) }
{ !! imageSizeOptions?.length && (
<ResolutionTool
value={ sizeSlug }
onChange={ updateImage }
options={ imageSizeOptions }
defaultValue={ DEFAULT_MEDIA_SIZE_SLUG }
/>
) }
</ToolsPanel>
</InspectorControls>
{ colorGradientSettings.hasColorsOrGradients && (
<InspectorControls group="color">
Expand Down
Loading