Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XDP] fixes to recent VE2 profiling #8702

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pgschuey
Copy link
Collaborator

@pgschuey pgschuey commented Jan 17, 2025

Problem solved by the commit

  • List of supported profile settings was missing tile_based_microcontroller_metrics
  • One last 8b -> 16b API change was needed
  • Support check for uC sets was incorrect
  • uC counter offset was missing
  • MDM utility functions were not accessible to client devices
  • MDM counter read was missing sample

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

  • None

How problem was solved, alternative solutions (if any) and why they were rejected

  • Added tile_based_microcontroller_metrics to supported list
  • Use 16b API on non-client builds
  • Corrected uC set check and added test set
  • Added uC counter offset
  • Moved MDM utility functions to util file
  • Added write of sample control bit to PCCMDR

Risks (if any) associated the changes in the commit

  • None

What has been tested and how, request additional testing if necessary

  • Tested on VE2 simulation

Documentation impact (if any)

  • Update list of supported profile settings in xrt.ini (VE2 only)

Paul Schumacher added 2 commits January 16, 2025 17:19
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
@pgschuey pgschuey requested a review from jvillarre as a code owner January 17, 2025 22:14
@pgschuey pgschuey marked this pull request as draft January 20, 2025 17:34
Paul Schumacher added 2 commits January 20, 2025 17:39
Signed-off-by: Paul Schumacher <[email protected]>
@pgschuey pgschuey changed the title [XDP] minor fixes to recent VE2 profiling [XDP] fixes to recent VE2 profiling Jan 20, 2025
@pgschuey pgschuey marked this pull request as ready for review January 20, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants