Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VITIS-13806 Fix helper scripts and return codes for xrt-smi #8716

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

rchane
Copy link
Collaborator

@rchane rchane commented Jan 24, 2025

Problem solved by the commit

https://jira.xilinx.com/browse/VITIS-13806

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

The xrt-smi and xbutil helper scripts weren't trying to get the loader and returned 0 due to a faulty if check.
(e.g. bin is still in the path on Windows MCDM and Linux amdxdna, so we should still be finding the loader)

How problem was solved, alternative solutions (if any) and why they were rejected

Fixed the if check. This should also preserve the original return behavior for edge platforms.

Risks (if any) associated the changes in the commit

N/A

What has been tested and how, request additional testing if necessary

Tested/built on amdxdna and MCDM.

$ xrt-smi configure --pmode performance
ERROR: Please specify a device using --device option
 Available devices:

$ echo $?
1

Documentation impact (if any)

N/A

@stsoe stsoe requested a review from rbramand-xilinx January 24, 2025 23:26
Copy link
Collaborator

@rbramand-xilinx rbramand-xilinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, checking if the string starts with /usr or /bin works with embedded platforms.

Copy link
Collaborator

@chvamshi-xilinx chvamshi-xilinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot remove xbutil as it is still being used in edge platforms. There were concerns in Ops review last week, We still need to keep xbutil for one more release.

@rchane
Copy link
Collaborator Author

rchane commented Jan 27, 2025

You cannot remove xbutil as it is still being used in edge platforms. There were concerns in Ops review last week, We still need to keep xbutil for one more release.

Thank you, Vamshi; I updated the PR and description accordingly.

@chvamshi-xilinx chvamshi-xilinx merged commit ba5cadc into Xilinx:master Jan 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants