Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting AWS clocking module using AWS API #8719

Merged
merged 1 commit into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 6 additions & 31 deletions src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -539,32 +539,6 @@ xocl_resolver(struct xocl_dev *xdev, struct axlf *axlf, xuid_t *xclbin_id,
return ret;
}

/* This is a Workaround function for AWS F2 to reset the clock registers.
* This function also incurs a delay of 10seconds to work around AWS ocl timeout issue.
* These changes will be removed once the issue is addressed in AWS F2 instance.
*/
void aws_reset_clock_registers(xdev_handle_t xdev)
{
struct xocl_dev_core *core = XDEV(xdev);
resource_size_t bar0_clk1, bar0_clk2;
void __iomem *vbar0_clk1, *vbar0_clk2;

userpf_info(xdev, "AWS F2 WA, waiting to reset clock registers after Load ");
msleep(10000);

bar0_clk1 = pci_resource_start(core->pdev, 0) + 0x4058014;
bar0_clk2 = pci_resource_start(core->pdev, 0) + 0x4058010;
vbar0_clk1 = ioremap_nocache(bar0_clk1, 32);
vbar0_clk2 = ioremap_nocache(bar0_clk2, 32);

iowrite32(0, vbar0_clk1);
iowrite32(0, vbar0_clk2);

iounmap(vbar0_clk1);
iounmap(vbar0_clk2);
return;
}

int
xocl_read_axlf_helper(struct xocl_drm *drm_p, struct drm_xocl_axlf *axlf_ptr,
uint32_t qos, uint32_t *slot)
Expand Down Expand Up @@ -796,11 +770,12 @@ xocl_read_axlf_helper(struct xocl_drm *drm_p, struct drm_xocl_axlf *axlf_ptr,
}
else {
userpf_info(xdev, "Loaded xclbin %pUb", &bin_obj.m_header.uuid);
/* Work around added for AWS F2 Instance to perform delay and reset clock registers */
if(core->pdev->device == 0xf010)
{
aws_reset_clock_registers(xdev);
}
/* Work around added for AWS F2 Instance to perform delay */
if(core->pdev->device == 0xf010)
{
userpf_info(xdev, "AWS F2 WA, waiting after AFI Load ");
msleep(10000);
}
}

out_done:
Expand Down
30 changes: 30 additions & 0 deletions src/runtime_src/core/pcie/tools/cloud-daemon/aws/aws_dev.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,26 @@ int AwsDev::awsLoadXclBin(const xclBin *buffer)
opt.afi_id = afi_id;
opt.slot_id = mBoardNumber;
retVal = fpga_mgmt_load_local_image_with_options(&opt);

if(imageInfoOld.spec.map[FPGA_APP_PF].device_id == 0xf010)
{
const clock_freq_topology* clockSection = get_clock_freq_from_axlf(axlfbuffer);
uint32_t clock_mains[4];

if(clockSection) {
for(int32_t i = 0; i < clockSection->m_count; i++) {
const struct clock_freq* clk = &(clockSection->m_clock_freq[i]);
clock_mains[i] = clk->m_freq_Mhz;
}
}

syslog(LOG_ERR, "WA to skip id=%x", imageInfoOld.spec.map[FPGA_APP_PF].device_id);
aws_clkgen_set_dynamic(mBoardNumber, 125 /*default */, clock_mains[2]/*clk_extra_b0*/,
clock_mains[3]/*clk_extra_c0*/, clock_mains[1]/*hbm*/, 0);

return 0;
}

if (retVal == FPGA_ERR_DRAM_DATA_RETENTION_NOT_POSSIBLE ||
retVal == FPGA_ERR_DRAM_DATA_RETENTION_FAILED ||
retVal == FPGA_ERR_DRAM_DATA_RETENTION_SETUP_FAILED) {
Expand Down Expand Up @@ -778,4 +798,14 @@ char *AwsDev::get_afi_from_axlf(const axlf *buffer)
return nullptr;
return afid;
}

const clock_freq_topology* AwsDev::get_clock_freq_from_axlf(const axlf *buffer)
{
const axlf_section_header *clk_header = xclbin::get_axlf_section(buffer, CLOCK_FREQ_TOPOLOGY);
char *clk_topo = const_cast<char *>(reinterpret_cast<const char *>(buffer));
clk_topo += clk_header->m_sectionOffset;

return (reinterpret_cast<const clock_freq_topology*>(clk_topo));
}

#endif
2 changes: 2 additions & 0 deletions src/runtime_src/core/pcie/tools/cloud-daemon/aws/aws_dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#ifndef INTERNAL_TESTING_FOR_AWS
#include "fpga_pci.h"
#include "fpga_mgmt.h"
#include "fpga_clkgen.h"
#include "hal/fpga_common.h"
#endif

Expand Down Expand Up @@ -115,6 +116,7 @@ class AwsDev
#else
int sleepUntilLoaded( const std::string &afi, fpga_mgmt_image_info* new_afi );
char* get_afi_from_axlf(const axlf * buffer);
const clock_freq_topology* get_clock_freq_from_axlf(const axlf *buffer);
int index;
#endif
};
Expand Down
Loading